Remove the ipa-multipoint library#315
Open
fab-10 wants to merge 1 commit into
Open
Conversation
The ipa-multipoint library is no longer needed, so drop the module and all of its integration points: - delete the ipa-multipoint module (Java binding, Rust JNI crate, tests and test resources) - remove the project from settings.gradle - remove build_ipa_multipoint from build.sh and the build sequence - remove the ipa-multipoint upload/download/jars steps from the CI build workflow - note the removal in the changelog Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
There was a problem hiding this comment.
Pull request overview
This pull request removes the ipa-multipoint module from the besu-native multi-module build, along with its build/CI integration points, because the library is no longer needed.
Changes:
- Removed
ipa-multipointfrom Gradle settings so it is no longer part of the build. - Removed
ipa-multipointnative build step frombuild.shand removed artifact upload/download + jar publishing steps from CI. - Documented the removal as a breaking change in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
settings.gradle |
Drops ipa-multipoint from the included Gradle modules list. |
build.sh |
Removes the build_ipa_multipoint function and eliminates it from the build sequence. |
.github/workflows/build.yml |
Removes ipa-multipoint native artifact handling and jar artifact upload steps from CI. |
CHANGELOG.md |
Notes the removal as a breaking change in the unreleased section. |
ipa-multipoint/** |
Deletes the module sources, JNI crate, tests, and test resources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ipa-multipoint library is no longer needed, so drop the module and
all of its integration points:
and test resources)
build workflow
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net