update eip 8037 to latest spec test#10185
Merged
daniellehrner merged 3 commits intobesu-eth:mainfrom Apr 7, 2026
Merged
Conversation
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Besu’s EIP-8037-related behavior and devnet reference fixtures to align with the latest execution-spec-tests release, specifically around removing per-tx state gas pre-checks and correcting CREATE initcode/state-gas ordering.
Changes:
- Bump execution-spec-tests devnet fixtures from
bal@v5.5.1tobal@v5.6.1(Gradle dependency + verification metadata). - Update EIP-8037 block/tx capacity pre-checks to consider regular gas only (state gas validated at block level).
- Reorder CREATE initcode max-size validation to happen before charging state gas.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/verification-metadata.xml | Updates checksum metadata for the new bal@v5.6.1 fixtures artifact. |
| ethereum/referencetests/build.gradle | Bumps the devnet fixtures dependency to bal@v5.6.1. |
| evm/.../AbstractCreateOperation.java | Validates MAX_INIT_CODE_SIZE before any state gas charging to match spec ordering. |
| ethereum/core/.../BlockGasAccountingStrategy.java | Removes per-tx “state dimension” capacity check; only regular gas is checked pre-exec. |
| ethereum/core/.../BlockGasAccountingStrategyTest.java | Updates/extends tests to reflect regular-gas-only block capacity checks. |
| ethereum/blockcreation/.../BlockSizeTransactionSelector.java | Updates docs to match regular-gas-only pre-check behavior. |
| ethereum/blockcreation/.../BlockSizeTransactionSelectorTest.java | Updates test comments to reflect the new pre-check semantics. |
evm/src/main/java/org/hyperledger/besu/evm/operation/AbstractCreateOperation.java
Show resolved
Hide resolved
evm/src/main/java/org/hyperledger/besu/evm/operation/AbstractCreateOperation.java
Show resolved
Hide resolved
…s deduction Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Update devnet reference tests to https://github.com/ethereum/execution-spec-tests/releases/tag/bal%40v5.6.1:
Per-tx state gas pre-check removal
CREATE state gas ordering (now active)
Code deposit halt state gas
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests