Implement aggregation in pipeline service#10202
Open
mirgee wants to merge 2 commits intobesu-eth:mainfrom
Open
Implement aggregation in pipeline service#10202mirgee wants to merge 2 commits intobesu-eth:mainfrom
mirgee wants to merge 2 commits intobesu-eth:mainfrom
Conversation
a442b48 to
ba1aa2a
Compare
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
ba1aa2a to
fb1c122
Compare
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
BlockAccessListDataRequest#doPersistis called for each batch of responses corresponding to the batched BAL requestGetBlockAccessListsMessage.Instead of committing those changes for each batch, this PR adds an aggregation pipe to the pipeline, which aggregates all the batches into a single list and commits the corresponding changes to the flat database in one atomic operation. This allows us to compare state of each account in the BALs with the account trie (which by that point is already healed).
TODO:
It is possible to avoid unchecked casts and rely on compile-time type safety by makingWe will do this laterinSingleBatchavailable only onPipelineBuilders withpipeEndbeing aReadPipe<List<T>>(e,g, those created byinBatches), but it might require a more invasive change.