Uniform notification to selectors on a bundle selection rollback#9558
Merged
fab-10 merged 3 commits intobesu-eth:mainfrom Dec 17, 2025
Merged
Conversation
f992f58 to
e8fdaea
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
e8fdaea to
3f11a63
Compare
macfarla
reviewed
Dec 12, 2025
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
macfarla
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
When selecting groups of related txs for block creation (aka bundles), a potential previously selected tx in the group, could be later not be selected anymore, due to the result of following txs in the same group.
This behavior, that is the result of the rollback of the group of txs, has a gap in the notifications sent to selectors, including plugin selectors, since in case of a rollback, only the
onTransactionNotSelectedmethod is called on the not selected tx of the group, while for selected but pending commit, but then reverted txs, that same method is not invoked.This PR fixes this gap, calling also the
onTransactionNotSelectedmethod, with not selected reasonSELECTED_ROLLBACK, for selected but pending commit, but then reverted txs.The notification are always sent in the order they are processed.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests