Draft
Conversation
Added checkbox to activate edt Restore other translation files than the english one Added logic to handle DSHOT edt checkbox in motors tab. Bumped API_VERSION to 1.46. Added dshot_edt setting to MSP_MOTOR_CONFIG frame. Added dshot_edt setting to MSP_SET_MOTOR_CONFIG frame. Updated API_VERSION in generate_filename. Fixed features in motors tab. Added exclusive selection between ESC_SENSOR and EDT options. Fixed a bug Fixed review findings Removed unecessary imports Fixed review findings Fixed review findings Added debug mode to match edt_events Betaflight branch Fixed RPM_LIMIT debug mode name Small refactoring to be coherent to current code style
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nerdCopter
requested changes
Aug 29, 2024
| FC.MOTOR_CONFIG.use_dshot_telemetry = data.readU8() != 0; | ||
| FC.MOTOR_CONFIG.use_esc_sensor = data.readU8() != 0; | ||
|
|
||
| if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_42)) { |
Member
There was a problem hiding this comment.
@haslinghuis , the need for if semver 1.42 is removed now correct?
| // Introduced in 1.42 | ||
| buffer.push8(FC.MOTOR_CONFIG.motor_poles); | ||
| buffer.push8(FC.MOTOR_CONFIG.use_dshot_telemetry ? 1 : 0); | ||
| if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_42)) { |
Member
There was a problem hiding this comment.
same as above (no need semver 1.42)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3262
Related to betaflight/betaflight#13855