-
-
Notifications
You must be signed in to change notification settings - Fork 963
Add support for ICM45605 and ICM45686 #4432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fe904b3
to
edcde22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pre-approving; dependent on firmware merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to be read for firmware merge
""" WalkthroughThe changes update how new sensor types are inserted into sensor arrays based on the API version. The utility function used for array insertion is switched to allow adding multiple elements at once. Specifically, three new sensor types are now inserted simultaneously after a specific existing sensor type, instead of adding just one. Other logic for removing deprecated sensors and adding virtual sensors remains unchanged. Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Preview URL: https://ca6433c8.betaflight-configurator.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/js/sensor_types.js
(2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/js/sensor_types.js (1)
src/js/utils/array.js (2)
addArrayElementsAfter
(35-43)removeArrayElement
(7-12)
🔇 Additional comments (3)
src/js/sensor_types.js (3)
4-4
: Import updated appropriately.The import statement has been correctly updated to include the new
addArrayElementsAfter
utility function while retaining the necessaryremoveArrayElement
andaddArrayElement
functions.
114-114
: Improved code maintainability for gyro sensors.The change consolidates what would have been multiple single-element additions into one function call, making the code more maintainable and easier to extend in the future when additional sensors need to be added.
120-120
: Improved code maintainability for accelerometer sensors.Similar to the gyro sensors change, this consolidates multiple operations into a single function call, improving code consistency and maintainability.
7f831d5
to
61ead58
Compare
Rebased |
|
Preview URL: https://e4c2e919.betaflight-configurator.pages.dev |
This pull request updates the
sensorTypes
function insrc/js/sensor_types.js
to enhance the handling of array modifications by replacing single-element additions with multi-element additions. It also updates the utility function used for this purpose.Updates to array modification logic:
addArrayElementAfter
withaddArrayElementsAfter
to allow adding multiple elements at once in thegyroElements
andaccElements
arrays. This simplifies the code and improves extensibility.Utility function update:
addArrayElementsAfter
fromutils/array
instead ofaddArrayElementAfter
, reflecting the new multi-element addition approach.Summary by CodeRabbit
New Features
Bug Fixes