Skip to content

add dyn_idle_start_increase parameter to header view #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024
Merged

add dyn_idle_start_increase parameter to header view #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2084,23 +2084,27 @@ <h5 class="modal-title-revision"></h5>
</thead>
<td name="dynamic_idle_min_rpm">
<label>Min RPM</label>
<input type="text" step="1" min="0" max="100" />
<input type="text" step="1" min="0" max="200" />
</td>
<td name='dyn_idle_p_gain'>
<label>P gain</label>
<input type="text" step="1" min="0" max="8" />
<input type="text" step="1" min="0" max="250" />
</td>
<td name='dyn_idle_i_gain'>
<label>I gain</label>
<input type="text" step="1" min="0" max="8" />
<input type="text" step="1" min="0" max="250" />
</td>
<td name="dyn_idle_d_gain">
<label>D gain</label>
<input type="text" step="1" min="0" max="100" />
<input type="text" step="1" min="0" max="250" />
</td>
<td name='dyn_idle_start_increase'>
<label>Start inc</label>
<input type="text" step="1" min="0" max="255" />
</td>
<td name='dyn_idle_max_increase'>
<label>Max inc</label>
<input type="text" step="1" min="0" max="8" />
<input type="text" step="1" min="0" max="255" />
</td>
</tr>
</tbody>
Expand Down
2 changes: 2 additions & 0 deletions src/flightlog_parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ export function FlightLogParser(logData) {
dyn_idle_p_gain: null,
dyn_idle_i_gain: null,
dyn_idle_d_gain: null,
dyn_idle_start_increase: null,
dyn_idle_max_increase: null,
simplified_pids_mode: null, // Simplified / slider PIDS
simplified_pi_gain: null,
Expand Down Expand Up @@ -745,6 +746,7 @@ export function FlightLogParser(logData) {
case "dyn_idle_p_gain":
case "dyn_idle_i_gain":
case "dyn_idle_d_gain":
case "dyn_idle_start_increase":
case "dyn_idle_max_increase":
case "simplified_pids_mode":
case "simplified_pi_gain":
Expand Down
2 changes: 2 additions & 0 deletions src/header_dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ export function HeaderDialog(dialog, onSave) {
{name:'dyn_idle_p_gain' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.3.0', max:'999.9.9'},
{name:'dyn_idle_i_gain' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.3.0', max:'999.9.9'},
{name:'dyn_idle_d_gain' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.3.0', max:'999.9.9'},
{name:'dyn_idle_start_increase' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.5.0', max:'999.9.9'},
{name:'dyn_idle_max_increase' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.3.0', max:'999.9.9'},
{name:'simplified_pids_mode' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.3.0', max:'999.9.9'},
{name:'simplified_pi_gain' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.3.0', max:'999.9.9'},
Expand Down Expand Up @@ -847,6 +848,7 @@ export function HeaderDialog(dialog, onSave) {
setParameter('dyn_idle_p_gain' , sysConfig.dyn_idle_p_gain, 0);
setParameter('dyn_idle_i_gain' , sysConfig.dyn_idle_i_gain, 0);
setParameter('dyn_idle_d_gain' , sysConfig.dyn_idle_d_gain, 0);
setParameter('dyn_idle_start_increase' , sysConfig.dyn_idle_start_increase, 0);
setParameter('dyn_idle_max_increase' , sysConfig.dyn_idle_max_increase, 0);
renderSelect('simplified_pids_mode' , sysConfig.simplified_pids_mode, SIMPLIFIED_PIDS_MODE);
setParameter('simplified_pi_gain' , sysConfig.simplified_pi_gain, 0);
Expand Down