Skip to content

Bug fix for flight modes names at the chart #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/flightlog_fields_presenter.js
Original file line number Diff line number Diff line change
Expand Up @@ -1337,15 +1337,19 @@ FlightLogFieldPresenter.presentFlags = function (flags, flagNames) {
FlightLogFieldPresenter.presentChangeEvent = function presentChangeEvent(
flags,
lastFlags,
flagNames
) {
flagNames)
{
let eventState = "";
let found = false;

for (let i = 0; i < flagNames.length; i++) {
const maxModeNumber = 32; // int has 32 bit only! We have not to roll bit shift 1<<i for i values grate then 31 !!!
let modesCount = flagNames.length
if (modesCount > maxModeNumber) {
modesCount = maxModeNumber;
}
for (let i = 0; i < modesCount; i++) {
if ((1 << i) & (flags ^ lastFlags)) {
// State Changed
eventState += `|${flagNames[i]} ${(1 << i) & flags ? "ON" : "OFF"}`;
eventState += `${found ? "|" : ""}${flagNames[i]} ${(1 << i) & flags ? "ON" : "OFF"}`;
found = true;
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/grapher.js
Original file line number Diff line number Diff line change
Expand Up @@ -629,11 +629,11 @@ export function FlightLogGrapher(
drawEventLine(
x,
labelY,
`Flight Mode Change${FlightLogFieldPresenter.presentChangeEvent(
FlightLogFieldPresenter.presentChangeEvent(
event.data.newFlags,
event.data.lastFlags,
FLIGHT_LOG_FLIGHT_MODE_NAME
)}`,
),
"rgba(0,0,255,0.75)",
3
);
Expand Down