-
-
Notifications
You must be signed in to change notification settings - Fork 166
The min-max control context menu at the chart config dialog #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+289
−35
Merged
Changes from 4 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c9f5c02
Added draft for min-max control context menu
demvlad 65491dd
Added missing emitUpdate() call
demvlad 28a16a4
Added checking for field.curve.MinMax fields
demvlad 565ed54
Code style improvement
demvlad 8e5cb80
Removed yarn.lock
demvlad eb17832
Created menu architecture. Improved data struct field checking
demvlad d9df809
Resolved missing comma
demvlad f0df8f8
The One scale minmax menu action set uncentered scale
demvlad 1254235
Added proper label for selected curves submenu
demvlad 396f9de
Added action for Full range minmax control menu
demvlad ff91fc4
Added handler for the selected field submenu 'Full range' item
demvlad f1002dc
Added handler for the selected field submenu 'Centered' item
demvlad 6c3789b
Added handler for the selected field submenu 'Default' item
demvlad dcc7f46
Added arrow symbol into submenu label
demvlad c7bbf69
Added Zoom actions for minmax control menu
demvlad 8073761
Using special portal container for the minmax control context menu
demvlad f91489a
Added guard for minmax values input
demvlad 7b25f04
The one emit is used for all the zoomed curves
demvlad d498935
The minmax control menu does not close after zoom action
demvlad 13d891b
The currentState and menuItems are reference now
demvlad de0b0ae
Code style improvement
demvlad ae1dd76
The one context menu is used for the both minmax input fields
demvlad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.