Added high precise mode for the curves min-max values change step#921
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough
ChangesCurve Bounds Precision Control
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/GraphConfigDialog.vue`:
- Around line 181-186: The keydown handler in GraphConfigDialog.vue is toggling
field.curve.highPrecise for any Ctrl+key combo and preventing default, which
breaks standard shortcuts; update the keydown handlers for both the min and max
inputs (the inline handler that references field.curve.highPrecise) to only
toggle when the actual Control key is pressed (e.g., check e.key === 'Control'
or equivalent) and remove the e.preventDefault() so Ctrl+A/C/V/Z continue to
work.
- Around line 637-641: The truthy check `if (min && max)` incorrectly skips
cases where min or max is 0; update the conditional around where `min` and `max`
are read (the block setting `field.curve.highPrecise`) to test for explicit
null/undefined (e.g., `min != null && max != null`) so zero values are accepted,
then keep the existing logic using `normalMinMaxStep` to compute
`field.curve.highPrecise`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: df90cecb-6108-4b11-96d8-615b5cf0bfc2
📒 Files selected for processing (1)
src/components/GraphConfigDialog.vue
|
|
Preview URL: https://pr921.betaflight-blackbox.pages.dev |



The current version has fixed step (10) to change min-max values at the graphs setup page. But the 10 value is not comfortable for some fields, because the all values rounding up to 10.

This PR adds high precise mode for the curves min-max values change step.
Press the Ctrl key on selected Min-Max field input, to switch On/Off this mode
The min-max values change step is 0.1 in the high precise mode. It is possible to input any value.
The high precise input shows italic font.
Summary by CodeRabbit