Skip to content

Conversation

@qqqlab
Copy link
Contributor

@qqqlab qqqlab commented Jan 2, 2026

Remove #define USE_LED_STRIP -> gives error while compiling with cloud build:

***** Commencing Build *****

VERSION:   2026.6.0-alpha
COMMIT:    536d4d2c5a92bb3bc6d3684097d4ca6636c67d5f
CONTAINER: master
BOARD:     MADFLIGHT_FC3/RP2350B
STARTED:   2026-01-02 07:47:25Z

...

In file included from ./src/main/platform.h:30,
                 from ./src/main/common/streambuf.c:24:
./src/config/configs/MADFLIGHT_FC3/config.h:57: error: "USE_LED_STRIP" redefined [-Werror]
   57 | #define USE_LED_STRIP
      | 
<command-line>: note: this is the location of the previous definition
cc1: all warnings being treated as errors

...

Summary by CodeRabbit

  • Chores
    • Removed LED strip compilation macro from the flight controller configuration, disabling LED strip-related functionality during the build process.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 2, 2026

Walkthrough

Removed the USE_LED_STRIP preprocessor macro from the MADFLIGHT_FC3 flight controller configuration header file while retaining the LED_STRIP_PIN definition, effectively disabling compilation paths dependent on this macro.

Changes

Cohort / File(s) Change Summary
LED Strip Configuration
configs/MADFLIGHT_FC3/config.h
Removed public macro USE_LED_STRIP from RGB LED section; LED_STRIP_PIN remains defined

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Fix BETAFPVG473_V2 #820 — Removes the same USE_LED_STRIP macro from a different board configuration, applying a consistent pattern across multiple flight controller configs.

Suggested reviewers

  • nerdCopter
  • ot0tot
  • blckmn

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the technical issue (compilation error) but does not follow the repository's mandatory pull request template for hardware reviews. Add required sections from the template: confirm schematics review, hardware testing, guideline compliance, connector standards adherence, flight testing, and checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and accurately describes the main change: removing the USE_LED_STRIP define from config.h.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a04724e and 3c51ca6.

📒 Files selected for processing (1)
  • configs/MADFLIGHT_FC3/config.h
💤 Files with no reviewable changes (1)
  • configs/MADFLIGHT_FC3/config.h
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Setup Build Environment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@osirisinferi
Copy link
Contributor

To be thorough and for reviewers checking this PR: I checked the entire repo: there are 7 other targets also including the LED strip define, but all of those have an #ifndef guard around it. Thus they don't need fixing.

@haslinghuis haslinghuis merged commit 53b5f06 into betaflight:master Jan 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants