Add DAKEFPVF405X8 #612
Closed
Add DAKEFPVF405X8 #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslinghuis
requested changes
Nov 19, 2024
Member
haslinghuis
left a comment
haslinghuis
left a comment
There was a problem hiding this comment.
Have not checked timers and DMA
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Mark Haslinghuis <[email protected]>
ot0tot
reviewed
Nov 26, 2024
Comment on lines
+71
to
+72
| #define LED0_PIN PC14 | ||
| #define LED1_PIN PC15 |
Contributor
There was a problem hiding this comment.
Suggested change
| #define LED0_PIN PC14 | |
| #define LED1_PIN PC15 | |
| #define LED0_PIN PC14 | |
| #define LED1_PIN PC15 |
These pins cannot be used to drive LEDs
Contributor
|
I think we have decided the F405 cannot reliably support 8 motor outputs. Recommend H743 for X8, or reduce the number of motor outputs to use F405. |
Contributor
Author
OK. I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schematics and configuration files have been emailed to [email protected].
Please review. Thank you.