Skip to content

Conversation

@sugaarK
Copy link
Member

@sugaarK sugaarK commented Nov 22, 2024

No description provided.

@nerdCopter nerdCopter changed the title new iflight target IFLIGHT_BORG_F435 Nov 22, 2024
@nerdCopter

This comment was marked as off-topic.

@haslinghuis
Copy link
Member

haslinghuis commented Dec 2, 2024

Copy link
Member Author

@sugaarK sugaarK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Jason-iFlight
Copy link

it’s tested already and it have been pass

TIMER_PIN_MAP( 3, PB1, 2, 2 ) \
TIMER_PIN_MAP( 4, PC8, 2, 1 ) \
TIMER_PIN_MAP( 5, PC9, 2, 3 ) \
TIMER_PIN_MAP( 6, PB6, 1, 11 ) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DMA request conflicts with ADC1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is said that this ADC1 uses DMA to cause conflict, but ADC-CURR does not use this function due to inaccurate data, and I will disable this function.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we removing adc1 define

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is said that this ADC1 uses DMA to cause conflict, but ADC-CURR does not use this function due to inaccurate data, and I will disable this function.

What does this mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it mean we can move this one out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move what one of of where?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jason-iFlight you have been asked questions... HERE....

#define MANUFACTURER_ID IFRC

// LEDS
#define LED0_PIN PC15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PC15 cannot be used to drive a status LED

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LED drive current can be controlled at 3mA,and meet the requirements of the specification(we have check the specification),so PC15 can be used to drive a status LED.

#define PINIO1_PIN PC14

// TIMERS & DMA
#define TIMER_PIN_MAPPING TIMER_PIN_MAP( 0, PA8, 1, 8 ) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do not consider the 4 motors of the motor 58, only the 4 motors of 14 can be used, is it that these conflicts do not exist?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we removing motors 5-8?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@sugaarK
Copy link
Member Author

sugaarK commented Jan 14, 2025

@Jason-iFlight needs some changes

#define UART6_RX_PIN PC7
#define UART6_TX_PIN PC6
#define USB_DETECT_PIN PC5
#define SERIALRX_UART SERIAL_PORT_USART2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UART2 is susceptible to DFU hijacking and should not be used for receivers/GPS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uart2 will not use on receiver and GPS,However, UART2 is used as power callback, power callback only works when the battery is powered on, there is no conflict in entering DFU, because entering DFU is usually USB powered state, and the battery is powered off.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uart2 will not use on receiver and GPS,However, UART2 is used as power callback, power callback only works when the battery is powered on, there is no conflict in entering DFU, because entering DFU is usually USB powered state, and the battery is powered off.

What does this mean? What is "power callback"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will not use it for receivers/GPS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show the wiring guide for this FC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sugaarK
Copy link
Member Author

sugaarK commented Feb 18, 2025

@Jason-iFlight this will need retesting and PROPER testing... you would have had issues with the conflicts...

@sugaarK
Copy link
Member Author

sugaarK commented Mar 4, 2025

can you address any of the issues?

@nerdCopter
Copy link
Member

  • rebased it on master, and force-pushed.
  • fixed the space in the folder-name.

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving for workflow only.
  • did not deeply review, but did read some conversations
  • defer to other devs for validating the config.

@sugaarK
Copy link
Member Author

sugaarK commented May 26, 2025

@ot0tot this thing is in production.. they understand it will not be accepted to bring us a target like this already in production next time or they will be ignored.. can you commit any changes we can make in firmware and then we will approve as is.. this is the final time of this though next time we will simply reject a target like this.

@ot0tot
Copy link
Contributor

ot0tot commented Jun 9, 2025

This seems to be the same as the old https://github.com/betaflight/config/blob/master/configs/IFLIGHT_BLITZ_F435/config.h target. Why do we need to add this also?

If they're not willing to correct any of the design issues, might as well just use the old grandfathered target.

@Jason-iFlight
Copy link

Jason-iFlight commented Jun 11, 2025 via email

@sugaarK
Copy link
Member Author

sugaarK commented Jun 11, 2025

This seems to be the same as the old https://github.com/betaflight/config/blob/master/configs/IFLIGHT_BLITZ_F435/config.h target. Why do we need to add this also?

If they're not willing to correct any of the design issues, might as well just use the old grandfathered target.

would be easier and less hassle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants