-
Notifications
You must be signed in to change notification settings - Fork 221
IFLIGHT_BORG_F435 #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
IFLIGHT_BORG_F435 #614
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
sugaarK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
|
it’s tested already and it have been pass |
configs/ IFLIGHT_BORG_F435/config.h
Outdated
| TIMER_PIN_MAP( 3, PB1, 2, 2 ) \ | ||
| TIMER_PIN_MAP( 4, PC8, 2, 1 ) \ | ||
| TIMER_PIN_MAP( 5, PC9, 2, 3 ) \ | ||
| TIMER_PIN_MAP( 6, PB6, 1, 11 ) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DMA request conflicts with ADC1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is said that this ADC1 uses DMA to cause conflict, but ADC-CURR does not use this function due to inaccurate data, and I will disable this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we removing adc1 define
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is said that this ADC1 uses DMA to cause conflict, but ADC-CURR does not use this function due to inaccurate data, and I will disable this function.
What does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it mean we can move this one out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move what one of of where?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jason-iFlight you have been asked questions... HERE....
| #define MANUFACTURER_ID IFRC | ||
|
|
||
| // LEDS | ||
| #define LED0_PIN PC15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PC15 cannot be used to drive a status LED
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LED drive current can be controlled at 3mA,and meet the requirements of the specification(we have check the specification),so PC15 can be used to drive a status LED.
| #define PINIO1_PIN PC14 | ||
|
|
||
| // TIMERS & DMA | ||
| #define TIMER_PIN_MAPPING TIMER_PIN_MAP( 0, PA8, 1, 8 ) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motor outputs are split over 4 timers, which is not acceptable.
https://betaflight.com/docs/development/manufacturer/manufacturer-design-guidelines#32-resource-selection-considerations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we do not consider the 4 motors of the motor 58, only the 4 motors of 14 can be used, is it that these conflicts do not exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we removing motors 5-8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah
|
@Jason-iFlight needs some changes |
| #define UART6_RX_PIN PC7 | ||
| #define UART6_TX_PIN PC6 | ||
| #define USB_DETECT_PIN PC5 | ||
| #define SERIALRX_UART SERIAL_PORT_USART2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UART2 is susceptible to DFU hijacking and should not be used for receivers/GPS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uart2 will not use on receiver and GPS,However, UART2 is used as power callback, power callback only works when the battery is powered on, there is no conflict in entering DFU, because entering DFU is usually USB powered state, and the battery is powered off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uart2 will not use on receiver and GPS,However, UART2 is used as power callback, power callback only works when the battery is powered on, there is no conflict in entering DFU, because entering DFU is usually USB powered state, and the battery is powered off.
What does this mean? What is "power callback"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will not use it for receivers/GPS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you show the wiring guide for this FC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jason-iFlight HERE
|
@Jason-iFlight this will need retesting and PROPER testing... you would have had issues with the conflicts... |
|
can you address any of the issues? |
Co-authored-by: ot0tot <[email protected]>
Co-authored-by: ot0tot <[email protected]>
Co-authored-by: ot0tot <[email protected]>
remove motors 5-8
|
nerdCopter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- approving for workflow only.
- did not deeply review, but did read some conversations
- defer to other devs for validating the config.
|
@ot0tot this thing is in production.. they understand it will not be accepted to bring us a target like this already in production next time or they will be ignored.. can you commit any changes we can make in firmware and then we will approve as is.. this is the final time of this though next time we will simply reject a target like this. |
|
This seems to be the same as the old https://github.com/betaflight/config/blob/master/configs/IFLIGHT_BLITZ_F435/config.h target. Why do we need to add this also? If they're not willing to correct any of the design issues, might as well just use the old grandfathered target. |
|
Yes, we understand. If this request is approved, we will make the necessary changes in the future and introduce them subsequently.
张健
***@***.***
…------------------ 原始邮件 ------------------
发件人: ***@***.***>;
发送时间: 2025年5月26日(星期一) 中午12:04
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [betaflight/config] IFLIGHT_BORG_F435 (PR #614)
sugaarK left a comment (betaflight/config#614)
@ot0tot this thing is in production.. they understand it will not be accepted to bring us a target like this already in production next time or they will be ignored.. can you commit any changes we can make in firmware and then we will approve as is.. this is the final time of this though next time we will simply reject a target like this.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
would be easier and less hassle |
No description provided.