add GEPRC_TAKER_F405AIO #748
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslinghuis
requested changes
Apr 27, 2025
Comment on lines
+62
to
+63
| #define LED0_PIN PC14 | ||
| #define LED1_PIN PC15 |
There was a problem hiding this comment.
LED pins should not use PC13, PC14 or PC15
See https://betaflight.com/docs/development/manufacturer/manufacturer-design-guidelines#3146-leds
| TIMER_PIN_MAP( 1, PA8 , 1, 1) \ | ||
| TIMER_PIN_MAP( 2, PA9 , 1, 1) \ | ||
| TIMER_PIN_MAP( 3, PA10, 1, 1) \ | ||
| TIMER_PIN_MAP( 4, PC8 , 2, 1) |
There was a problem hiding this comment.
Missing timer, dma for LED_STRIP_PIN (PB1)
Comment on lines
+94
to
+95
| #define MAG_I2C_INSTANCE (I2CDEV_1) | ||
| #define BARO_I2C_INSTANCE (I2CDEV_1) |
There was a problem hiding this comment.
Suggested change
| #define MAG_I2C_INSTANCE (I2CDEV_1) | |
| #define BARO_I2C_INSTANCE (I2CDEV_1) | |
| #define BARO_I2C_INSTANCE I2CDEV_1 | |
| #define MAG_I2C_INSTANCE I2CDEV_1 |
| #define GYRO_1_SPI_INSTANCE SPI1 | ||
| #define GYRO_1_ALIGN CW180_DEG | ||
| #define GYRO_1_ALIGN_YAW 2700 | ||
|
|
There was a problem hiding this comment.
The whole file has one space in front of every line after license.
Suggested change
| #define FLASH_SPI_INSTANCE SPI3 | ||
| #define GYRO_1_SPI_INSTANCE SPI1 | ||
| #define GYRO_1_ALIGN CW180_DEG | ||
| #define GYRO_1_ALIGN_YAW 2700 |
There was a problem hiding this comment.
Only GYRO_[12]_ALIGN CUSTOM uses RPY related defines
Suggested change
| #define GYRO_1_ALIGN_YAW 2700 |
Comment on lines
+40
to
+43
| #define MOTOR1_PIN PA8 | ||
| #define MOTOR2_PIN PA9 | ||
| #define MOTOR3_PIN PA10 | ||
| #define MOTOR4_PIN PC8 |
There was a problem hiding this comment.
Using two GPIO ports is not optimal. See https://betaflight.com/docs/development/manufacturer/manufacturer-design-guidelines#32-resource-selection-considerations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.