Skip to content

add disable gyro clock #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

cvetaevvitaliy
Copy link
Contributor

@cvetaevvitaliy cvetaevvitaliy commented May 3, 2025

add disable gyro clock for testing and comparing results ICM42688P

Usage

  • add -DUSE_DISABLE_GYRO_CLKIN using EXTRA_FLAGS for local build
  • add DISABLE_GYRO_CLKIN using custom define for cloud build

@ot0tot
Copy link
Contributor

ot0tot commented May 3, 2025

Why not just disable the resource in the CLI?

@cvetaevvitaliy
Copy link
Contributor Author

cvetaevvitaliy commented May 3, 2025 via email

@SteveCEvans
Copy link
Member

Why not just disable the resource in the CLI?

Exactly my thought. That’s easy and obvious, whereas build options are not so easily remembered and have a habit of becoming broken over time when the code is updated and their significance is overlooked.

@cvetaevvitaliy
Copy link
Contributor Author

Why not just disable the resource in the CLI?

Exactly my thought. That’s easy and obvious, whereas build options are not so easily remembered and have a habit of becoming broken over time when the code is updated and their significance is overlooked.

Only non-developer wouldn't do this. Finally it's only for one target and as part of testing this feature for a quick comparison - Enable/Disable gyro clock

@ot0tot
Copy link
Contributor

ot0tot commented May 4, 2025

If only for testing it makes even more sense to just do it in the CLI. No need to recompile the firmware and reflash.

@SteveCEvans
Copy link
Member

Exactly. Once tested and proven it would be dead, unused complexity.

@haslinghuis
Copy link
Member

Closing as developers can just disable the pin (no need for new local define)

@haslinghuis haslinghuis closed this May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants