Skip to content

Conversation

@HGLRC-T
Copy link
Contributor

@HGLRC-T HGLRC-T commented Nov 12, 2025

Summary by CodeRabbit

  • New Features
    • Added support for the HGLRC_H743_DUAL flight controller board.
    • Configured dual gyros, accelerometer, barometer, onboard flash (blackbox), and OSD support.
    • Multiple UART, I2C and SPI interfaces and peripheral mappings for sensors, MAX7456, and flash.
    • Pin/timer mappings for motors, servos, beeper, LED strip, and ADC-based voltage/current sensing.
    • Added user-configurable extra IO/box options and sensible defaults for meters and beeper.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

Walkthrough

Adds a new Betaflight configuration header for the HGLRC_H743_DUAL board (STM32H743). Declares board identity, enabled sensors/peripherals (dual gyros, accel, baro, flash, OSD) and comprehensive pin, SPI/I2C, timer, ADC, DMA, and device default mappings.

Changes

Cohort / File(s) Summary
HGLRC_H743_DUAL Board Configuration
configs/HGLRC_H743_DUAL/config.h
New board config header defining MCU/board IDs and manufacturer; enables gyro/accel/baro/flash/MAX7456; declares dual-gyro CS/EXTI/CLKIN, SPI instances and alignments; maps SPI1–SPI4 pins, FLASH/MAX7456 CS and instances; UART1–UART8, I2C1, ADC (VBAT/CURRENT) pins; motor (1–8) and servo (1–3) timer mappings; LED strip, beeper (inverted); DMA options; default blackbox device and meter scales; extra PINIO/BOX configs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • Add New Target DAKEFPVH743Pro #793: Adds an STM32H743 board config header with the same macro set (dual-gyro CS/EXTI/CLKIN, SPI/I2C pins, timer mappings, DMA options).
  • Add AXISFLYING_H743PRO #972: Introduces another STM32H743 board configuration that declares equivalent board-level macros (sensors, SPI instances, ADC/timer mappings).
  • Add SPEDIXH743 #791: Adds an HGLRC STM32H743 board config with matching feature flags and peripheral pin mappings (dual gyros, SPI/I2C, timers, DMA).

Suggested reviewers

  • ot0tot
  • haslinghuis
  • nerdCopter
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely missing, failing to address mandatory requirements for hardware compliance, review status, and required checklist items. Add a comprehensive description addressing all mandatory sections: hardware compliance requirements, schematic review status, testing confirmation, guideline adherence, and completion of the required checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a new board configuration for HGLRC_H743_DUAL.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0665d5 and 2f65f3a.

📒 Files selected for processing (1)
  • configs/HGLRC_H743_DUAL/config.h
🚧 Files skipped from review as they are similar to previous changes (1)
  • configs/HGLRC_H743_DUAL/config.h

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ot0tot
Copy link
Contributor

ot0tot commented Nov 13, 2025

Feedback provided in Discord. Does not follow BF Manufacturer Guidelines.

@HGLRC-T HGLRC-T closed this Dec 16, 2025
@HGLRC-T HGLRC-T reopened this Dec 16, 2025
@HGLRC-T
Copy link
Contributor Author

HGLRC-T commented Dec 17, 2025

I have updated the config.h file of HGLRC_H743_DUAL according to the approved schematic diagram, please check it.

@sugaarK sugaarK added the Partner Program this pr is for a target from the partner program and will automatically get tier 1 status label Dec 18, 2025
@HGLRC-T
Copy link
Contributor Author

HGLRC-T commented Jan 5, 2026

Thanks to the community for their feedback. I have already rebased and forced a new change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner Program this pr is for a target from the partner program and will automatically get tier 1 status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants