Skip to content

Conversation

@HGLRC-T
Copy link
Contributor

@HGLRC-T HGLRC-T commented Dec 18, 2025

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • New Features
    • Added support for the HGLRC_F405_S flight controller (STM32F405).
    • Enabled gyro (ICM42688P), accelerometer, DPS310 barometer, onboard flash and OSD.
    • Preconfigured motor and LED timer mappings plus comprehensive pin assignments for UART, I2C, SPI, ADC, beeper and other signals.
    • Set sensible defaults: blackbox storage, inverted beeper option, meter sources/scales, and BOX/PINIO mappings with extra serial port configs.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Walkthrough

Adds a new board configuration header for HGLRC_F405_S (STM32F405) declaring board IDs, enabling ICM42688P gyro/accel, DPS310 barometer, M25P16 flash, MAX7456 OSD, and providing comprehensive pin/timer/I2C/SPI/ADC/EXTI/BOX/blackbox defaults and mappings.

Changes

Cohort / File(s) Summary
HGLRC_F405_S Board Configuration
configs/HGLRC_F405_S/config.h
New config header: sets FC_TARGET_MCU, BOARD_NAME, MANUFACTURER_ID; enables peripherals (USE_GYRO, USE_ACC, USE_BARO, USE_FLASH, USE_MAX7456 and specific IC variants); extensive pin mappings (beeper, motors, UARTs, I2C, LEDs, SPI, gyro, flash, ADCs, EXTI, misc); TIMER_PIN_MAPPING; ADC/DMA/instance macros; I2C/SPI instances and CS pins; gyro clock-in pin; meter defaults/scales, BEEPER_INVERTED, DEFAULT_BLACKBOX_DEVICE; PINIO/BOX pins and names.

Sequence Diagram(s)

(omitted — configuration-only change; no multi-component runtime control flow introduced)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Add HGLRCF435_AIO board #884 — Adds similar HGLRC board config headers enabling ICM42688P, DPS310, M25P16, MAX7456 and defining GYRO_1_CLKIN, TIMER_PIN_MAPPING, ADC and UART pin assignments.

Suggested labels

Awaiting prototype samples, Schematics approved

Suggested reviewers

  • haslinghuis
  • ot0tot
  • nerdCopter
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description only includes a checklist with mixed completion status but lacks all required template sections including mandatory hardware compliance details, design guideline confirmation, and connector standards verification. Add complete description with all template sections: hardware compliance details, schematics review confirmation, guidelines adherence explanation, connector standards verification, and flight testing status. Replace template placeholder text with actual PR details.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add HGLRC_F405_S board' directly and clearly summarizes the main change—adding a new flight controller board configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sugaarK sugaarK added the Partner Program this pr is for a target from the partner program and will automatically get tier 1 status label Dec 18, 2025
@osirisinferi osirisinferi mentioned this pull request Dec 27, 2025
6 tasks
@HGLRC-T HGLRC-T force-pushed the HGLRC_F405_S branch 3 times, most recently from 7769788 to 1fff64a Compare December 29, 2025 15:55
@HGLRC-T
Copy link
Contributor Author

HGLRC-T commented Jan 4, 2026

Done. Let's merge~

@osirisinferi
Copy link
Contributor

Done. Let's merge~

Do you want to have CAM2 selected by default? If not, please see my comment above.

@HGLRC-T
Copy link
Contributor Author

HGLRC-T commented Jan 4, 2026

Done. Let's merge~

Do you want to have CAM2 selected by default? If not, please see my comment above.

Thanks. I know your mean. And fixed it.

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All current HGLRC targets don't use a underscore in their name.

@HGLRC-T
Copy link
Contributor Author

HGLRC-T commented Jan 5, 2026

All current HGLRC targets don't use a underscore in their name.

Yes, we previously used uppercase letters for connections, but we found that this wasn't very clear. Therefore, starting in the second half of 2025, we hope that new targets will use underscores for connections, which will improve user recognition of target files.

@haslinghuis haslinghuis requested a review from ot0tot January 6, 2026 20:36
@HGLRC-T
Copy link
Contributor Author

HGLRC-T commented Jan 9, 2026

Good. Let's merge~

@haslinghuis haslinghuis merged commit 3e29656 into betaflight:master Jan 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner Program this pr is for a target from the partner program and will automatically get tier 1 status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants