🗺️ Change map#1192
Open
BmnQuentin wants to merge 13 commits intodevfrom
Open
Conversation
Collaborator
florianpanchout
left a comment
florianpanchout
left a comment
There was a problem hiding this comment.
Ce serait cool d'en profiter pour rajouter des tests sur cette partie de l'app
| return ( | ||
| <div className="h-full w-full flex flex-col bg-alt-grey"> | ||
| <div className="flex gap-2 px-6 border-b border-b-border-default-grey min-h-[4.35rem] justify-between items-center sticky top-0 bg-lifted-grey z-10"> | ||
| <SegmentedControl |
Collaborator
There was a problem hiding this comment.
Il faut lui donner une valeur par défaut sinon il va toujours afficher tableau au chargement même si on a #carte
Collaborator
Author
There was a problem hiding this comment.
J'ai un peu galéré et finalement avec Claude on aconvergé vers quelque chose qui affecte tout segmented control (et donc aussi le finance switch). Ca tourne bien, je te laisse me dire si ok pour toi !
Collaborator
florianpanchout
left a comment
florianpanchout
left a comment
There was a problem hiding this comment.
Et j'ai un problème de largeur du menu différent entre la carte et le tableau. Je pense qu'il faudrait ajouter un shrink-0 sur le Menu
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| createdMap.once("remove", () => cleanupInteractions()); | ||
| }); | ||
|
|
||
| const resizeObserver = new ResizeObserver(() => createdMap.resize()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.