Conversation
Alezco
force-pushed
the
operateur-documents
branch
from
b028984 to
0c5778b
Compare
Alezco
force-pushed
the
operateur-documents
branch
from
0c5778b to
6458882
Compare
Alezco
force-pushed
the
operateur-documents
branch
from
6458882 to
19b4d5d
Compare
| {filteredCategories.map(([category, rules], index) => { | ||
| return ( | ||
| <div key={category}> | ||
| <FieldSetDocumentOperateur |
Collaborator
There was a problem hiding this comment.
Est-ce qu'il ne faudrait pas utiliser les mêmes composants que pour structure ? Ici FieldSetActeAdministratif
| vulnerabilites, | ||
| documents: operateur.documents.map((document) => ({ | ||
| ...document, | ||
| date: document.date ? new Date(document.date).toISOString() : undefined, |
Collaborator
There was a problem hiding this comment.
À quoi sert le new Date(document.date).toISOString() ? Soit c'est déjà un Date, soit c'est déjà un iso non ?
| date: document.date ? new Date(document.date).toISOString() : undefined, | ||
| fileUploads: document.fileUploads?.map((file) => ({ | ||
| ...file, | ||
| acteAdministratifId: file.acteAdministratifId ?? undefined, |
Collaborator
There was a problem hiding this comment.
Le passage null => undefined devrait plutôt avoir lieu dans getDocumentsOperateurDefaultValues pour être cohérent avec les autres entités
| <ModificationTitle | ||
| step="Documents" | ||
| handleCancel={() => setShouldOpenModal(true)} | ||
| />{" "} |
| }; | ||
|
|
||
| type OperateurWithStructures = Prisma.OperateurGetPayload<{ | ||
| type OperateurWithStructuresAndDocuments = Prisma.OperateurGetPayload<{ |
Collaborator
There was a problem hiding this comment.
Tu pourrais le renommer OperateurDbDetail et le bouger dans operateur.db.type.ts pour être iso avec structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.