🥷 Move contacts to dotenv#1208
Open
BmnQuentin wants to merge 3 commits intodevfrom
Open
Conversation
|
|
||
| export default function ModificationControleForm() { | ||
| const { structure } = useStructureContext(); | ||
| const BHASILE_CONTACT_EMAIL = |
Collaborator
There was a problem hiding this comment.
On ne pourrait pas laisser ça dans constants ? Histoire d'éviter de le répeter partout
Collaborator
Author
There was a problem hiding this comment.
Quitte à changer le tel (par sécurité mais aussi pour que ce soit simple à modifier pour un non dev) je m disais que c'était bien de grouper avec le mail... Ca se discute en vrai
Collaborator
There was a problem hiding this comment.
Non, c'est bien de mettre tel et email dans les variables d'env. Par contre on peut mettre
const BHASILE_CONTACT_EMAIL = process.env.BHASILE_CONTACT_EMAIL || "";
const BHASILE_PHONE_NUMBERS =
process.env.NEXT_PUBLIC_BHASILE_PHONE_NUMBERS || "";
dans constants.ts, comme ça tu n'as pas à le réécrire dans chaque composant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.