🐛(ingestion-infrastructure) make ministry mapping more robust#548
Merged
Conversation
smdsgn
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
New GRECO csv files have new ministry naming. Concours cleaner was failing. This PR aims at making ministry mapping more generic and robust.
🏷️ Type of change
🔧 Changes
concours cleaner, more specifically _map_ministry method.
🛸 Required dependencies for this change (if applicable)
🏝️ How to test (if applicable)
Steps to reproduce or test
📸 Screenshots (if applicable)
✅ Checklist