Prise en compte des IBAN étrangers dans le post-traitement RIB#139
Merged
Conversation
Étend try_correct_false_iban aux IBAN non français (substitution et retrait d'un caractère OCR) et aligne post_processing_iban / post_processing_bank_account sur le même comportement que les IBAN FR : conservation si valide ou corrigeable, rejet sinon. Le retrait OCR est ignoré pour les IBAN FR de 27 caractères. Co-authored-by: Cursor <cursoragent@cursor.com>
trecouvr
reviewed
Jun 5, 2026
Collaborator
trecouvr
left a comment
trecouvr
left a comment
There was a problem hiding this comment.
OK, mais on dirait que les tests sont redondant. L'idée c'est de tester try_correct_false_iban à fond et les autres méthode de juste faire le cas nominal et une erreur courante.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
La mise à jour intervient surtout sur la correction de l'IBAN qui était pensée pour IBAN FR (27 caractères)
NoneNoneNoneFRvalideFRinvalide, corrigeable (substitution)FRinvalide, non corrigeableNone