Improved typing #784
Open
Improved typing #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I am not against dropping support for EOL 3.8, container type hints in 3.8 can be parametrised as long as they are imported from from typing import List, Dict, Tuple, SetWhat is not supported in 3.8 is parametrising the built-in classes (lowercase letters) since they do not support indexing: list[int] # Fails in 3.8 because class "list" does not support indexing
List[int] # Works in 3.8Admittedly, this would be a tad bit more work, but hardly insurmountable. |
|
@mzaja - of course. Let me rephrase: I am not going to make these changes 3.8 compatible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
Suggest we take this opportunity to drop support for Python 3.8 which is end of life and does not support parameterizing generic classes (dict, tuple, etc)