fix(register): resolve host JWT iss against id or kid - #29
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Paola3stefania
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per spec §4.2, the SDK signs host JWTs with
iss = JWK thumbprint. For hosts created via the enrollment-token flow, the thumbprint is stored in thekidcolumn, notid. The middleware already does a dual lookup:…but
/agent/registerand/agent/claimonly looked up byid. Pre-enrolled hosts therefore missed the lookup, fell through to the dynamic-registration branch, and threwdynamic_host_registration_disabledwhenever the operator had setallowDynamicHostRegistration: false.There was also a follow-on bug in the same routes: after signature verification they checked
payload.iss !== hostRecord.id, which would still reject a kid-resolved host even after the lookup was fixed. Both checks are nowpayload.iss !== hostRecord.id && payload.iss !== hostRecord.kid.No public API changes. No schema changes. Patch-level release.
Reported on Discord by
jtavares(2026-04-20).