Mirror image issues - #601
Open
leachryan wants to merge 2 commits into
Open
Conversation
added 2 commits
January 23, 2019 16:20
Fixed a performance issue occurring when dragging an element that contains child elements. A mirror image was being created for each child image as well as the containing element. This lead to performance issues when starting to drag and waiting for elements to settle, so that the element could be dropped. This fix just checks if a mirror image already exists, and if so, doesn't append another one.
Removed console.log statements previously commited
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a performance issue occurring when dragging an element that contains child elements. A mirror image was being created for each child image as well as the containing element. This lead to performance issues when starting to drag and waiting for elements to settle, so that the element could be dropped. This fix just checks if a mirror image already exists, and if so, doesn't append another one.