Merged
Conversation
Don't support diagnostic filters for now
JMS55
approved these changes
Jan 25, 2025
robtfm
approved these changes
Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how to handlediagnostic_filterordiagnostic_filter_leafcurrently. (see https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#the-diagnostic-directive-is-now-supported-in-wgsl for a description of what it is).Diagnostic filters are just unsupported for now, didn't have time to figure out how to get them actually working. There's a test for them but it's marked as
#[should_panic]due to the lack of support (also the current expected output for it is wrong as it isn't mangled, but I need them working in the first place to get the proper mangling so w/e).