add raycast special types (backport to 0.17)#118
Closed
JMS55 wants to merge 1 commit intobevyengine:0.17-branchfrom
Closed
add raycast special types (backport to 0.17)#118JMS55 wants to merge 1 commit intobevyengine:0.17-branchfrom
JMS55 wants to merge 1 commit intobevyengine:0.17-branchfrom
Conversation
Collaborator
|
@JMS55 can you please see if #119 works - i think it will better support multiple modules using the same special types, so should hopefully allow passing around the special types as well ( i changed the expected output for the atomics test - now it is outputting clearly invalid source (using an undefined type). but actually, the previous source was also invalid as the type was not the builtin type. it does work with the gpu-based shader test on my machine (though not in CI due to an unrelated error) so i'm comfortable it's still correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.