Warn on module replacement in add_composable_module#126
Open
SoulSharer wants to merge 1 commit intobevyengine:masterfrom
Open
Warn on module replacement in add_composable_module#126SoulSharer wants to merge 1 commit intobevyengine:masterfrom
add_composable_module#126SoulSharer wants to merge 1 commit intobevyengine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've hit a surprising behavior by accidentally adding same module twice.
I think it will be more fail proof to inform user that module is being replaced, invalidating everything that depends on it.
It should probably be an error to add the same module twice, but since I'm not sure whether current behavior is desirable I left it as is.