-
Notifications
You must be signed in to change notification settings - Fork 494
Fix filtering in area command filter + add tech level filtering #6212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix filtering in area command filter + add tech level filtering #6212
Conversation
f7048cf to
e2b2699
Compare
|
Apparently we don't want this behaviour. Now it's: Always filter units by target teamId. For enemies use ENEMY_UNITS (so all enemy teams). |
e2b2699 to
042f71f
Compare
042f71f to
ffb7b9c
Compare
|
Handled the comments + added a command limit, like in smart area reclaim |
alt - filter by unitDefId and teamId ctrl - filter by teamId. When targeting wreck, filter by techLevel instead
7e03452 to
11fdb65
Compare
sprunk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, modifier design is for somebody else to decide.
Fix
Recent tweak to this widget made it always target allies (so you could very easily reclaim allied buildings by accident).
I refactored it so that:
Always filter units by target teamId. For enemies use ENEMY_UNITS (so all enemy teams).
alt - filter by unitDefId and teamId
ctrl - filter by teamId. When targeting wreck, filter by techLevel
New feature
Holding Ctrl when targeting wrecks will filter by tech level. So now you can resurrect/reclaim only t2 units, etc
Test steps