fix: clusters bypass shields in shield rework #6277
+198
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
What incorrect info does engine provide? Isn't clusters going through shields because a cluster that explodes on a shield surface spawns submunitions inside the bubble? |
Collaborator
Author
That remark is not about the clusters but the power remaining, for overpen. In the shields rework, damage to shields is collected in a |
efrec
changed the title
added 6 commits
November 21, 2025 13:46
because the shield rework "covers" units until then and waits to apply shield damage until then which is an odd detail tbh: an infinite sub-frame hp pool
cludgy but it is what is is at this point
We want to stop using the engine API for shield data since our shield implementation is increasingly departing from the way the engine works.
We are still detecting shield hits only on direct contact, so this code, effectively, ignores shields that are a tiny distance away from a direct hit. This still causes some cluster shots to sneak through. I think this is a "sufficient" solution and gives good performance but I'll likely sweep through in a couple months once it bothers me enough and revamp hit detection.
This adds better support for shields to handle projectiles and removes some mysteriousness to how they are handled. I've excluded lightning sparks specifically since they deny their ownerID (it is always -1) and how would lightning know who's who, anyway (how, indeed, would any projectile know its own team, but whatever).
efrec
force-pushed
the
fix-cluster-shield-bypass-in-rework
branch
from
3fd1674 to
a06fa99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done
Addresses Issue(s)
From tests by OmicronMkI, clusters weren't treating non-repulsing shields as solid surfaces, so sometimes would bypass shields:
Test steps
/luarules fightertest legacluster corgate 10 1 2400Recording of that fightertest: https://discord.com/channels/549281623154229250/1063217502898884701/1441274985896480808
In addition, verify that overpen works the same as before. Railguns are LaserCannons so are not intercepted by shields normally. You have to give a t3 shield or enable the modoption to intercept all projectiles from advanced options.
I've done these steps and things seem to be working.