make selectable as combat override a customparam #6287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
This reverts commit 69ef9ed.
przystuj
reviewed
Nov 22, 2025
przystuj
approved these changes
Nov 22, 2025
sprunk
reviewed
Nov 26, 2025
Comment on lines
+93
to
+94
| local selectableAsCombat = udef.customParams and udef.customParams.selectable_as_combat_unit | ||
| if selectableAsCombat then |
Collaborator
There was a problem hiding this comment.
customParams is never nil
Suggested change
| local selectableAsCombat = udef.customParams and udef.customParams.selectable_as_combat_unit | |
| if selectableAsCombat then | |
| if udef.customParams.selectable_as_combat_unit then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was a dirty nasty ew ew stinky hard coded string.find. This PR makes it a customparam which everybody likes