Skip to content

Conversation

@SethDGamre
Copy link
Collaborator

@SethDGamre SethDGamre commented Nov 29, 2025

before:
image

After:
image

  • f4 works in legacy but doesn't work in gridmenu.
  • f4 tip doesn't belong in a banner
  • punctuation isn't appropriate for a banner
  • incorrect use of comma
  • moved the banner up a bit so notifications don't show under it
  • removed the text part of the notification for the voice line "Please Choose Your Starting Location"
  • removed a Spring.Echo I saw leftover from debugging

this is to make it so that it doesn't cover notifications, if there's notifications
bad grammer, punctuation not consistent with other ui, f4 doesn't match default gridmenu and doesn't belong in a banner
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025

Test Results

14 tests  ±0   7 ✅ ±0   9s ⏱️ ±0s
 1 suites ±0   7 💤 ±0 
 1 files   ±0   0 ❌ ±0 

Results for commit e685f74. ± Comparison against base commit b2d5568.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant