-
Notifications
You must be signed in to change notification settings - Fork 494
Quickstart refund rework #6341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SethDGamre
wants to merge
11
commits into
beyond-all-reason:master
Choose a base branch
from
SethDGamre:Quickstart-Refund-Rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Quickstart refund rework #6341
SethDGamre
wants to merge
11
commits into
beyond-all-reason:master
from
SethDGamre:Quickstart-Refund-Rework
+123
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR makes it so that if you:
then you can have the remaining budget refunded as metal.
Also makes the quickstart base-generation range dependent on budget size. Range reduced to 435 in allignment with zecrus' observation that many maps mex spacing are based on the range of an LLT. Not worth adding a comment, because maps aren't necessarily coupled to LLT range.