fix(restore): ensure trailing newline before appending to postgresql.conf#93
Merged
Conversation
…conf If a snapshot's postgresql.conf had no trailing newline, the first appended setting (log_destination) merged onto the last existing line, corrupting the config and breaking the restore. Append a blank line first; Postgres ignores it and the config is throwaway anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When restoring, the init script strips old logging/config settings from the snapshot's
postgresql.confwithsed, then appends replacements withecho ... >>.If the snapshot's
postgresql.confhad no trailing newline, the first appended setting merged onto the last existing line — e.g.timezone = 'UTC'log_destination = 'stderr'— corrupting the config and breaking the restore.Fix: append a blank line before the settings block. Postgres ignores blank lines and this config is throwaway per-restore, so an unconditional newline is the simplest safe fix.
🤖 Generated with Claude Code