Skip to content

Code itches

Josue Rios edited this page Feb 2, 2022 · 3 revisions

Things that are itchy about the code base that should probably be addressed at some point but don't have their own issues yet.

  • ScholarshipAmount sets min and max all the time even when they're 0. Maybe we should require they either be > 0 or blank/missing. This way we can save some storage/network data.
  • Maybe ScholarshipAmount should just be an interface and nothing else with helper related functions.
  • Maybe our FirebaseModel object with its data and id fields is too much. Maybe we should just read/write with the id field in the data itself and use class methods for reading/saving.
  • Maybe our experiment library should be a hook (e.g. useExperiment('foo')) or a component (e.g. below)?
    <Experiment key="showHello">
      hello
    </Experiment>

Clone this wiki locally