-
Notifications
You must be signed in to change notification settings - Fork 1
Code itches
Josue Rios edited this page Feb 2, 2022
·
3 revisions
Things that are itchy about the code base that should probably be addressed at some point but don't have their own issues yet.
-
ScholarshipAmountsetsminandmaxall the time even when they're 0. Maybe we should require they either be > 0 or blank/missing. This way we can save some storage/network data. - Maybe
ScholarshipAmountshould just be an interface and nothing else with helper related functions. - Maybe our
FirebaseModelobject with itsdataandidfields is too much. Maybe we should just read/write with theidfield in the data itself and use class methods for reading/saving. - Maybe our experiment library should be a hook (e.g.
useExperiment('foo')) or a component (e.g. below)?<Experiment key="showHello"> hello </Experiment>