Fix: Custom panel domains does not work.#41
Merged
bezhanSalleh merged 3 commits intobezhanSalleh:3.xfrom May 12, 2025
Merged
Conversation
PR Summary
|
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation does not work if you use custom domains for you different panels. It only uses the path you specify in your panel provider.
For example:
It might seem unnecessary to include a package for this, but this package is already included in Laravel 11.35+ so it should only be an extra dependency for projects that uses older versions of Laravel. This was better than to use the URL helper that shipps with Laravel 11.35+ as you would than have to require Laravel 11.35+.