Resume AudioContext on user interaction to fix Chrome audio#556
Merged
Conversation
Chrome and other browsers block AudioContext from starting until a user gesture occurs on the page. This caused no sound when navigating directly to a ROM page. Fix by listening for keydown/mousedown/touchstart events and calling audioCtx.resume() on the first interaction. Fixes #368 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome and other browsers block AudioContext from starting until a user gesture occurs on the page. This caused no sound when navigating directly to a ROM page on jsnes.org.
The fix listens for keydown/mousedown/touchstart events and automatically calls
audioCtx.resume()on the first interaction. Audio now starts seamlessly when users begin playing without requiring manual intervention.Fixes #368
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com