Skip to content

Spec cleanup: remove unimplemented artifact dedup semantics from External Results v1 #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bg-playground merged 2 commits into from
May 8, 2026
Merged

Spec cleanup: remove unimplemented artifact dedup semantics from External Results v1 #323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3711f37
Initial plan
Copilot May 8, 2026
e337c5a
docs(spec): remove unimplemented artifact dedup references
Copilot May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions docs/specs/external_results_v1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,9 +426,7 @@ When a runner POSTs a case result with an `external_id` that already exists for

Inserting a `(test_case_id, requirement_id)` link that already exists is a **no-op**. No error is raised.

### Artifacts — deduplication by SHA-256

If the body of a new artifact upload has the same SHA-256 as an artifact already attached to the same `case_result_id`, BGSTM returns the **existing artifact row** (`200 OK`) rather than creating a second copy. The `409` code in the error table above is the response shape, but the HTTP status is `200` (not an error condition — the caller's intent is fulfilled).
Artifact uploads are not deduplicated; reporters that retry an upload (for example on transient network errors) may create duplicate artifact rows, and this is acceptable for v0.1.

---

Expand Down Expand Up @@ -493,7 +491,6 @@ All error responses share a single envelope:
| `artifact.not_found` | Artifact UUID does not exist. |
| `artifact.too_large` | Artifact body exceeds size limit. |
| `artifact.unsupported_type` | `content_type` is not in the allowed list. |
| `artifact.duplicate` | Identical artifact already exists (see §d). |
| `validation_error` | Request body failed Pydantic schema validation. |
| `internal_error` | Unhandled server-side error. |

Expand Down
Loading