Skip to content

Stabilize RBAC admin/users e2e by anchoring forbidden checks to AdminRoute test id #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bg-playground merged 2 commits into from
May 8, 2026
Merged

Stabilize RBAC admin/users e2e by anchoring forbidden checks to AdminRoute test id #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4880575
Initial plan
Copilot May 8, 2026
5454aa9
fix(frontend): stabilize RBAC forbidden checks with admin-route testid
Copilot May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/AdminRoute.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const AdminRoute: React.FC<{ children: React.ReactNode }> = ({ children }) => {
if (!isAuthenticated) return <Navigate to="/login" replace />;
if (user?.role !== 'admin') {
return (
<div className="flex flex-col items-center justify-center min-h-[60vh] text-center">
<div data-testid="admin-route-forbidden" className="flex flex-col items-center justify-center min-h-[60vh] text-center">
<h1 className="text-4xl font-bold text-gray-800 mb-4">403</h1>
<p className="text-lg text-gray-600">Access Denied — Admin only.</p>
</div>
Expand Down
9 changes: 3 additions & 6 deletions frontend/tests/e2e/rbac.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ test.describe('RBAC – Viewer role', () => {
// 3. Redirect to login
const url = page.url();
const wasRedirected = !url.includes('/admin') || url.includes('/login');
const showsForbidden = await page
.getByText(/403|unauthorized|forbidden|access denied|not authorized/i)
.isVisible()
.catch(() => false);
const showsForbidden = await page.getByTestId('admin-route-forbidden').isVisible().catch(() => false);
const showsEmptyOrError = await page
.getByText(/no users|error|something went wrong/i)
.isVisible()
Expand Down Expand Up @@ -94,7 +91,7 @@ test.describe('RBAC – Admin role', () => {
expect(page.url()).not.toMatch(/\/login/);

// Should NOT see a 403/forbidden page
const isForbidden = await page.getByText(/403|forbidden|access denied/i).isVisible().catch(() => false);
const isForbidden = await page.getByTestId('admin-route-forbidden').isVisible().catch(() => false);
expect(isForbidden).toBe(false);
});
});
});
Loading