Skip to content

Fix critical CI failures: remove stale root configs, update actions to v4, add artifact upload - #26

Merged
bg-playground merged 2 commits into
mainfrom
copilot/fix-critical-ci-workflows
Mar 5, 2026
Merged

Fix critical CI failures: remove stale root configs, update actions to v4, add artifact upload#26
bg-playground merged 2 commits into
mainfrom
copilot/fix-critical-ci-workflows

Conversation

Copilot AI commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

CI was consistently failing due to stale root-level duplicates shadowing real configs and broken steps in the active workflows. Cleans up the root-level debris and brings both workflow files up to current standards.

Deleted (root-level duplicates)

  • automated-tests.yml — used Node 14, missing Playwright install
  • ci.yml — contained a npx tsc step; this project has no TypeScript
  • playwright.config.js — conflicted with automated-testing/playwright.config.js

.github/workflows/automated-tests.yml

  • actions/checkout@v2v4
  • actions/setup-node@v3v4
  • Added artifact upload step (test-results-automated, 30-day retention, if: always())

.github/workflows/ci.yml

  • actions/checkout@v2v4
  • Added missing actions/setup-node@v4 (Node 18) — step was absent entirely
  • Added artifact upload step (test-results-ci, 30-day retention, if: always())
- name: Upload test results
  uses: actions/upload-artifact@v4
  if: always()
  with:
    name: test-results-ci   # test-results-automated in the other workflow
    path: |
      automated-testing/playwright-report/
      automated-testing/test-results/
    retention-days: 30
Original prompt

Critical CI Fixes

The CI workflows on main are consistently failing. This PR should fix all critical CI issues:

1. Delete duplicate/outdated root-level workflow and config files

The following files at the repository root are duplicates of files that already exist in their correct locations. They are outdated, confusing, and non-functional. Delete them:

  • automated-tests.yml (root) — outdated duplicate of .github/workflows/automated-tests.yml, uses Node 14 and missing Playwright install
  • ci.yml (root) — outdated duplicate of .github/workflows/ci.yml, has broken npx tsc step
  • playwright.config.js (root) — duplicate of automated-testing/playwright.config.js with conflicting settings

2. Fix .github/workflows/ci.yml

The active CI workflow at .github/workflows/ci.yml currently has a "Build TypeScript" step that runs npx tsc. This project is 100% JavaScript — there is no TypeScript or tsconfig.json. This step always fails.

Remove this step from .github/workflows/ci.yml:

      - name: Build TypeScript
        run: npx tsc
        working-directory: ./automated-testing

Also add an "Install Playwright Browsers" step (with --with-deps) before the "Run tests" step, since the current ci.yml is missing it (unlike automated-tests.yml which has it):

      - name: Install Playwright Browsers
        working-directory: ./automated-testing
        run: npx playwright install --with-deps

3. Update all GitHub Actions to v4

In both .github/workflows/automated-tests.yml and .github/workflows/ci.yml, update:

  • actions/checkout@v2actions/checkout@v4
  • actions/setup-node@v2 or actions/setup-node@v3actions/setup-node@v4

4. Add test artifact upload to workflows

Add an artifact upload step to both workflow files so test results are preserved on failure. Add this step at the end of each workflow:

      - name: Upload test results
        uses: actions/upload-artifact@v4
        if: always()
        with:
          name: test-results
          path: |
            automated-testing/playwright-report/
            automated-testing/test-results/
          retention-days: 30

Note: For ci.yml, use artifact name test-results-ci and for automated-tests.yml use test-results-automated to avoid conflicts if both run on the same commit.

Summary of file changes:

  • Delete: automated-tests.yml (root), ci.yml (root), playwright.config.js (root)
  • Modify: .github/workflows/automated-tests.yml — update action versions, add artifact upload
  • Modify: .github/workflows/ci.yml — remove npx tsc step, add Playwright install step, update action versions, add artifact upload

This pull request was created from Copilot chat.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ions, add artifact upload

Co-authored-by: bg-playground <259109604+bg-playground@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix critical CI issues by updating workflows Fix critical CI failures: remove stale root configs, update actions to v4, add artifact upload Mar 5, 2026
@bg-playground
bg-playground marked this pull request as ready for review March 5, 2026 19:04
@bg-playground
bg-playground merged commit 5633cc2 into main Mar 5, 2026
1 check failed
@bg-playground
bg-playground deleted the copilot/fix-critical-ci-workflows branch March 5, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants