ci: lint commits and PR title with commitlint (Phase 1)#121
Merged
Conversation
Add commitlint (config-conventional) on each PR commit and a PR-title check (the squash subject that feeds release-please). Implements ADR-0002. https://claude.ai/code/session_01EESGRwTzyd1G16yv7R2Eqd
bgauduch
added
the
adr-not-needed
Claude
This was referenced Jun 15, 2026
Owner
Author
Décision de review — passer en « Option B » (commitlint seul, actions officielles)Après discussion avec le mainteneur, on remplace l'approche actuelle (deux actions tierces) par une implémentation DIY qui n'utilise que des actions officielles Pourquoi
Cible (Option B)
Rattachement roadmapImplémente toujours ADR-0002 (donc label La mise en œuvre se fera dans une session dédiée à cette branche ( Posté à la demande du mainteneur. Generated by Claude Code |
Rework per maintainer review (#121): drop the third-party wagoid/commitlint-github-action and amannn/action-semantic-pull-request. One workflow runs commitlint (the @commitlint/* packages) on both the PR commits and the PR title, via official actions/checkout + actions/setup-node. commitlint.config.mjs stays the single rule source. Still implements ADR-0002. https://claude.ai/code/session_01EESGRwTzyd1G16yv7R2Eqd
The previous commit only removed lint-pr-title.yml; this carries the reworked commitlint.yml (official actions + commitlint for commits and PR title). Implements ADR-0002 per the #121 review. https://claude.ai/code/session_01EESGRwTzyd1G16yv7R2Eqd
Owner
Author
|
Done — reworked to Option B (commit
Which do you prefer? Generated by Claude Code |
bgauduch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Roadmap Phase 1 — enforce Conventional Commits (ADR-0002) using commitlint as the single rule engine, on both the PR commits and the PR title.
Changes
commitlint.config.mjs— extends@commitlint/config-conventional(the single source of the rules)..github/workflows/commitlint.yml— one workflow that, using only officialactions/*+ the@commitlint/*packages:commitlint --from $BASE_SHA --to $HEAD_SHA),Design — "Option B" (no third-party actions)
Drops
wagoid/commitlint-github-actionandamannn/action-semantic-pull-requestin favour of running commitlint directly. One engine, one ruleset (commitlint.config.mjs), smaller supply-chain surface — and no parser drift between two tools. The PR title is the load-bearing check (it becomes the squash subject); per-commit linting is kept for a tidy PR history.ADR
No new ADR — implements existing ADR-0002.
adr-not-neededapplied (touches.github/workflows/).Follow-up
actions/*to commit digests — deferred to the repo-wide supply-chain pass (Phase 5 / epic: supply chain security #99); maintainable via Renovate digest pinning now that chore: extend Renovate and retire Dependabot (Phase 1) #122 has landed.