Skip to content

fix: btc path #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+55 −2
Open

fix: btc path #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ce11ce
fix: btc path
sakulstra Nov 11, 2025
4841c7b
fix: add balance diff
sakulstra Nov 11, 2025
bfdc67b
fix: add a comment
sakulstra Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/contracts/MigrationHelper.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@ contract MigrationHelper is Ownable, IMigrationHelper {
aTokenAmountToMigrate = aTokenBalanceAfterReceiving;
}

uint256 withdrawn = V2_POOL.withdraw(asset, aTokenAmountToMigrate, address(this));
uint256 balanceBefore = IERC20WithPermit(asset).balanceOf(address(this));
V2_POOL.withdraw(asset, aTokenAmountToMigrate, address(this));
uint256 withdrawn = IERC20WithPermit(asset).balanceOf(address(this)) - balanceBefore;

// there are cases when we transform asset before supplying it to v3
(address assetToSupply, uint256 amountToSupply) = _preSupply(asset, withdrawn);
Expand Down
37 changes: 36 additions & 1 deletion tests/MigrationHelper.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import {console} from 'forge-std/console.sol';

import {AaveV2Polygon} from 'aave-address-book/AaveV2Polygon.sol';
import {AaveV3Polygon} from 'aave-address-book/AaveV3Polygon.sol';

import {AaveV2Ethereum, AaveV2EthereumAssets} from 'aave-address-book/AaveV2Ethereum.sol';
import {AaveV2EthereumAMM} from 'aave-address-book/AaveV2EthereumAMM.sol';
import {AaveV3Ethereum, AaveV3EthereumAssets} from 'aave-address-book/AaveV3Ethereum.sol';
import {IERC20} from 'solidity-utils/contracts/oz-common/interfaces/IERC20.sol';
import {ICreditDelegationToken} from '../src/interfaces/ICreditDelegationToken.sol';
import {IERC20WithATokenCompatibility} from './helpers/IERC20WithATokenCompatibility.sol';
Expand Down Expand Up @@ -467,3 +469,36 @@ contract MigrationHelperTest is Test {
return creditDelegations;
}
}

contract MigrationHelperMainnetTest is Test {
MigrationHelper public migrationHelper;

function setUp() public {
vm.createSelectFork(vm.rpcUrl('mainnet'), 23643694);
migrationHelper = new MigrationHelper(AaveV3Ethereum.POOL, AaveV2Ethereum.POOL);
}

function test_reproduction() external {
vm.startPrank(0x7A087e630f7d50544513967B1c68839458C16526);

IERC20(AaveV2EthereumAssets.WBTC_A_TOKEN).approve(address(migrationHelper), type(uint256).max);
IERC20(AaveV2EthereumAssets.DAI_A_TOKEN).approve(address(migrationHelper), type(uint256).max);
ICreditDelegationToken(AaveV3EthereumAssets.USDC_V_TOKEN).approveDelegation(
address(migrationHelper),
type(uint256).max
);

address[] memory assetsToMigrate = new address[](2);
assetsToMigrate[0] = 0x2260FAC5E5542a773Aa44fBCfeDf7C193bc2C599;
assetsToMigrate[1] = 0x6B175474E89094C44Da98b954EedeAC495271d0F;
IMigrationHelper.RepaySimpleInput[]
memory positionsToRepay = new IMigrationHelper.RepaySimpleInput[](1);
positionsToRepay[0] = IMigrationHelper.RepaySimpleInput({
asset: 0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48,
rateMode: 2
});
IMigrationHelper.PermitInput[] memory permits;
IMigrationHelper.CreditDelegationInput[] memory credDel;
migrationHelper.migrate(assetsToMigrate, positionsToRepay, permits, credDel);
}
}
Loading