-
Notifications
You must be signed in to change notification settings - Fork 77
feat: add filtering functions to address book #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📊 Package size report 0.6%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
139d855 to
af1e746
Compare
af1e746 to
71fe29f
Compare
sakulstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine overall
af3aefa to
354afdb
Compare
so that entries can be found by properties and still be type-safe
354afdb to
7d73dd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds type-safe filtering functions to the address book, enabling developers to find entries by their properties while maintaining compile-time type safety.
- Introduces
filterAddressesfunction for finding multiple entries matching criteria - Adds
findAddressfunction for finding exactly one entry with error handling - Implements supporting type definitions for type-safe filtering
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ts/utils.ts | Implements the new filtering functions with type definitions |
| tests/utils.spec.ts | Adds comprehensive tests for the new filtering functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
so that entries can be found by properties and still be type-safe