-
Notifications
You must be signed in to change notification settings - Fork 77
feat: generate emode label #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📊 Package size report 0.03%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
src/ChainlinkArbitrum.sol
Outdated
| library ChainlinkArbitrum { | ||
| // https://arbiscan.io/address/0x8d0CC5f38f9E802475f2CFf4F9fc7000C2E1557c | ||
| address internal constant AAPL_USD = 0x8d0CC5f38f9E802475f2CFf4F9fc7000C2E1557c; | ||
| address internal constant AAPL___USD = 0x8d0CC5f38f9E802475f2CFf4F9fc7000C2E1557c; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps cleaner to not update the chainlink constants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why, currently is a bit confusing that is _ for everything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no strong opinion, just feel its cleaner to have single _ on chainlink and also we don't have more than two assets with separation on the name like we do on emodes 😅
No description provided.