Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard EURC on V3 Base #620

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Rozengarden
Copy link
Contributor

No description provided.

Copy link

:finnadie:Test Results Compiling 317 files with Solc 0.8.22 Solc 0.8.22 finished in 143.97s Compiler run successful!

Ran 3 tests for src/20250219_AaveV3Base_AddEURCToBASEAaveV3/AaveV3Base_AddEURCToBASEAaveV3_20250219.t.sol:AaveV3Base_AddEURCToBASEAaveV3_20250219_Test
[FAIL: revert: 29] test_EURCAdmin() (gas: 1992542)
[FAIL: revert: 29] test_collectorHasEURCFunds() (gas: 1992564)
[FAIL: revert: 29] test_defaultProposalExecution() (gas: 5368625)
Suite result: FAILED. 0 passed; 3 failed; 0 skipped; finished in 11.75s (16.89s CPU time)

Ran 1 test suite in 11.76s (11.75s CPU time): 0 tests passed, 3 failed, 0 skipped (3 total tests)

Failing tests:
Encountered 3 failing tests in src/20250219_AaveV3Base_AddEURCToBASEAaveV3/AaveV3Base_AddEURCToBASEAaveV3_20250219.t.sol:AaveV3Base_AddEURCToBASEAaveV3_20250219_Test
[FAIL: revert: 29] test_EURCAdmin() (gas: 1992542)
[FAIL: revert: 29] test_collectorHasEURCFunds() (gas: 1992564)
[FAIL: revert: 29] test_defaultProposalExecution() (gas: 5368625)

Encountered a total of 3 failing tests, 0 tests succeeded

@brotherlymite
Copy link
Contributor

@Rozengarden can you seed the executor or mock it, so the tests passes so you can add the diff snapshots.

rateStrategyParams: IAaveV3ConfigEngine.InterestRateInputData({
optimalUsageRatio: 90_00,
baseVariableBorrowRate: 0,
variableRateSlope1: 12_00,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rozengarden can you double check with risk that the slope1 at 12% is the latest one, considering we reduced it for other EUR stablecoins around a week back via this proposal

@Rozengarden
Copy link
Contributor Author

@Rozengarden can you seed the executor or mock it, so the tests passes so you can add the diff snapshots.

executor was funded, forgot to bump block height 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants