Skip to content

Conversation

@Rozengarden
Copy link
Contributor

@Rozengarden Rozengarden commented Dec 31, 2025

Pre-review checklist:

  • I have run a spell check on the write-up and made sure no typos exist.
  • References to Snapshot/governance forum are correct on the AIP. If no snapshot exists, make sure no TODO's exist.
  • The specification on the writeup is aligned with the forum, snapshot, and the payload contract. If there are any changes, they are explicitly mentioned/communicated.
  • Minimal tests exist, and the snapshot diff report generated is the latest one and aligned with the payload.
  • If deploy scripts are manually updated from the generated ones, I have carefully validated that they are correct, including the deploy commands and the proposal-creation script.
  • If the aave-helpers submodule is updated, I have validated it is pointing to the latest version.
  • I have validated that no unused files and imports are being added.
  • For an asset listing, the write-up includes a detailed specification of the price feed used, CAPO adapters (with each CAPO layer described separately), and eModes (with tables) if changed.
  • Wherever possible, I have validated that addresses from the address book are used instead of raw addresses.

Copy link
Contributor

@NandyBa NandyBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to update PR and forum to distribute aLidoGHO instead of GHO

Copy link
Contributor

@NandyBa NandyBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@Rozengarden Rozengarden marked this pull request as ready for review January 2, 2026 09:07
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

🌈Test Results Compiling 313 files with Solc 0.8.27 Solc 0.8.27 finished in 63.44s Compiler run successful! 2026-01-06T10:04:45.108938Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/aave-cli@^1.4.5", "diff-snapshots", "./reports/AaveV3EthereumLido_OrbitProgramRenewalQ1AndQ22026_20251231_before.json", "./reports/AaveV3EthereumLido_OrbitProgramRenewalQ1AndQ22026_20251231_after.json", "-o", "./diffs/AaveV3EthereumLido_OrbitProgramRenewalQ1AndQ22026_20251231_before_AaveV3EthereumLido_OrbitProgramRenewalQ1AndQ22026_20251231_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/[email protected]\n"

Ran 2 tests for src/20251231_AaveV3EthereumLido_OrbitProgramRenewalQ1AndQ22026/AaveV3EthereumLido_OrbitProgramRenewalQ1AndQ22026_20251231.t.sol:AaveV3EthereumLido_OrbitProgramRenewalQ1AndQ22026_20251231_Test
[PASS] test_defaultProposalExecution() (gas: 26431875)
Logs:
0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0
0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
0xdC035D45d973E3EC169d2276DDab16f1e407384F
0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48
0xbf5495Efe5DB9ce00f80364C8B423567e58d2110
0x9D39A5DE30e57443BfF2A8307A4256c8797A3497
0xA1290d69c65A6Fe4DF752f95823fae25cB99e5A7
0xD11c452fc99cF405034ee446803b6F6c1F6d5ED8
E2E: Collateral wstETH, TestAsset wstETH
SUPPLY: wstETH, Amount: 27520441440671328895
SUPPLY: wstETH, Amount: 2752044144067132889
WITHDRAW: wstETH, Amount: 1376022072033566444
WITHDRAW: wstETH, Amount: 1376022072033566443
BORROW: wstETH, Amount 2752044144067132889
REPAY: wstETH, Amount: 2752044144067132890
REPAY: wstETH, Amount: 2752044144067132890
LIQUIDATE: wstETH, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 2752044144067132890
LIQUIDATE: wstETH, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 2752044144067132890
FLASH LOAN: wstETH, Amount: 2752044144067132889
FLASH LOAN: wstETH, Amount: 2752044144067132889
E2E: Collateral wstETH, TestAsset WETH
SUPPLY: wstETH, Amount: 27520441440671328895
SUPPLY: WETH, Amount: 3366462466030710486
WITHDRAW: WETH, Amount: 1683231233015355243
WITHDRAW: WETH, Amount: 1683231233015355242
BORROW: WETH, Amount 3366462466030710486
REPAY: WETH, Amount: 3366462466030710487
REPAY: WETH, Amount: 3366462466030710487
LIQUIDATE: WETH, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 3366462466030710487
LIQUIDATE: WETH, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 3366462466030710487
FLASH LOAN: WETH, Amount: 3366462466030710486
FLASH LOAN: WETH, Amount: 3366462466030710486
E2E: Collateral wstETH, TestAsset USDS
SUPPLY: wstETH, Amount: 27520441440671328895
SUPPLY: USDS, Amount: 10004863764470459669263
WITHDRAW: USDS, Amount: 5002431882235229834631
WITHDRAW: USDS, Amount: 5002431882235229834629
BORROW: USDS, Amount 10004863764470459669263
REPAY: USDS, Amount: 10004863764470459669264
REPAY: USDS, Amount: 10004863764470459669264
LIQUIDATE: USDS, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10004863764470459669264
LIQUIDATE: USDS, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10004863764470459669264
FLASH LOAN: USDS, Amount: 10004863764470459669263
FLASH LOAN: USDS, Amount: 10004863764470459669263
E2E: Collateral wstETH, TestAsset USDC
SUPPLY: wstETH, Amount: 27520441440671328895
SUPPLY: USDC, Amount: 10003196121
WITHDRAW: USDC, Amount: 5001598060
WITHDRAW: USDC, Amount: 5001598059
BORROW: USDC, Amount 10003196121
REPAY: USDC, Amount: 10003196122
REPAY: USDC, Amount: 10003196122
LIQUIDATE: USDC, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10003196122
LIQUIDATE: USDC, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10003196122
FLASH LOAN: USDC, Amount: 10003196121
FLASH LOAN: USDC, Amount: 10003196121
E2E: Collateral wstETH, TestAsset ezETH
SUPPLY: wstETH, Amount: 27520441440671328895
SUPPLY: ezETH, Amount: 3150990656608825408
WITHDRAW: ezETH, Amount: 1575495328304412704
WITHDRAW: ezETH, Amount: 1575495328304412704
E2E: Collateral wstETH, TestAsset sUSDe
SUPPLY: wstETH, Amount: 27520441440671328895
SUPPLY: sUSDe, Amount: 8248151170728967723837
WITHDRAW: sUSDe, Amount: 4124075585364483861918
WITHDRAW: sUSDe, Amount: 4124075585364483861917
FLASH LOAN: sUSDe, Amount: 8248151170728967723837
E2E: Collateral wstETH, TestAsset GHO
SUPPLY: wstETH, Amount: 27520441440671328895
SUPPLY: GHO, Amount: 10000000000000000000000
WITHDRAW: GHO, Amount: 5000000000000000000000
WITHDRAW: GHO, Amount: 4999999999999999999998
BORROW: GHO, Amount 10000000000000000000000
REPAY: GHO, Amount: 10000000000000000000001
REPAY: GHO, Amount: 10000000000000000000001
LIQUIDATE: GHO, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10000000000000000000001
LIQUIDATE: GHO, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10000000000000000000001
FLASH LOAN: GHO, Amount: 10000000000000000000000
FLASH LOAN: GHO, Amount: 10000000000000000000000
E2E: Collateral wstETH, TestAsset rsETH
SUPPLY: wstETH, Amount: 27520441440671328895
SUPPLY: rsETH, Amount: 3170972386597668026
WITHDRAW: rsETH, Amount: 1585486193298834013
WITHDRAW: rsETH, Amount: 1585486193298834012
FLASH LOAN: rsETH, Amount: 3170972386597668026
E2E: Collateral wstETH, TestAsset tETH
SUPPLY: wstETH, Amount: 27520441440671328895
SUPPLY: tETH, Amount: 2735696500819785964
WITHDRAW: tETH, Amount: 1367848250409892982
WITHDRAW: tETH, Amount: 1367848250409892982
FLASH LOAN: tETH, Amount: 2735696500819785964

[PASS] test_streamCreation() (gas: 1118705)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 35.02s (36.52s CPU time)

Ran 1 test suite in 35.03s (35.02s CPU time): 2 tests passed, 0 failed, 0 skipped (2 total tests)

marczeller and others added 6 commits January 5, 2026 09:23
…/AaveV3EthereumLido_OrbitProgramRenewalQ1AndQ22026_20251231.sol

Co-authored-by: Harsh Pandey <[email protected]>
…/AaveV3EthereumLido_OrbitProgramRenewalQ1AndQ22026_20251231.sol

Co-authored-by: Harsh Pandey <[email protected]>
…/OrbitProgramRenewalQ1AndQ22026.md

Co-authored-by: Harsh Pandey <[email protected]>
…/OrbitProgramRenewalQ1AndQ22026.md

Co-authored-by: Harsh Pandey <[email protected]>
…/OrbitProgramRenewalQ1AndQ22026.md

Co-authored-by: Harsh Pandey <[email protected]>
…/OrbitProgramRenewalQ1AndQ22026.md

Co-authored-by: Harsh Pandey <[email protected]>
TepNik
TepNik previously approved these changes Jan 5, 2026
…/OrbitProgramRenewalQ1AndQ22026.md

Co-authored-by: Harsh Pandey <[email protected]>
Rozengarden and others added 3 commits January 5, 2026 16:37
…/OrbitProgramRenewalQ1AndQ22026.md

Co-authored-by: Harsh Pandey <[email protected]>
…/OrbitProgramRenewalQ1AndQ22026.md

Co-authored-by: Harsh Pandey <[email protected]>
@brotherlymite brotherlymite merged commit 4cb55e7 into bgd-labs:main Jan 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants