Skip to content

Conversation

@NandyBa
Copy link
Contributor

@NandyBa NandyBa commented Jan 6, 2026

Pre-review checklist:

  • I have run a spell check on the write-up and made sure no typos exist.
  • References to Snapshot/governance forum are correct on the AIP. If no snapshot exists, make sure no TODO's exist.
  • The specification on the writeup is aligned with the forum, snapshot, and the payload contract. If there are any changes, they are explicitly mentioned/communicated.
  • Minimal tests exist, and the snapshot diff report generated is the latest one and aligned with the payload.
  • If deploy scripts are manually updated from the generated ones, I have carefully validated that they are correct, including the deploy commands and the proposal-creation script.
  • If the aave-helpers submodule is updated, I have validated it is pointing to the latest version.
  • I have validated that no unused files and imports are being added.
  • For an asset listing, the write-up includes a detailed specification of the price feed used, CAPO adapters (with each CAPO layer described separately), and eModes (with tables) if changed.
  • Wherever possible, I have validated that addresses from the address book are used instead of raw addresses.

Copy link
Contributor

@ianflexa ianflexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just fix the "Sable" -> Stable typo and re-run tests to generate diffs again?
Rest looks good

@NandyBa NandyBa force-pushed the aavechan/trydo-stablecoin-ir branch from 1076b3c to 249fefb Compare January 7, 2026 17:12
@NandyBa NandyBa force-pushed the aavechan/trydo-stablecoin-ir branch from 249fefb to 6aadd1d Compare January 7, 2026 17:12
@NandyBa NandyBa changed the title feat: trydo sablecoin ir feat: trydo stablecoin ir Jan 7, 2026
@NandyBa
Copy link
Contributor Author

NandyBa commented Jan 7, 2026

Could you just fix the "Sable" -> Stable typo and re-run tests to generate diffs again? Rest looks good

Done in 6aadd1d

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

:finnadie:Test Results Compiling 316 files with Solc 0.8.27 Solc 0.8.27 finished in 63.48s Compiler run successful! 2026-01-08T08:23:20.940260Z ERROR sharedbackend: Failed to send/recv `storage` err=failed to get storage for 0x4cd13ce4edbB5523fd4849252b5f1bF215129D10 at 24440054405305269366569402256811496959409073762505157381672968839269610695612: Max retries exceeded HTTP error 429 with body: { "message": "Your current usage exceeds the limits for our public endpoints. To access higher rate limits, please visit https://nodies.app and create an account to set up private endpoints. For enterprise usage, please contact [email protected]" } address=0x4cd13ce4edbB5523fd4849252b5f1bF215129D10 index=24440054405305269366569402256811496959409073762505157381672968839269610695612

Ran 1 test for src/20260107_AaveV3InkWhitelabel_TrydoStablecoinIR/AaveV3InkWhitelabel_TrydoStablecoinIR_20260107.t.sol:AaveV3InkWhitelabel_TrydoStablecoinIR_20260107_Test
[FAIL: EVM error; database error: failed to get storage for 0x4cd13ce4edbB5523fd4849252b5f1bF215129D10 at 24440054405305269366569402256811496959409073762505157381672968839269610695612: Max retries exceeded HTTP error 429 with body: {
"message": "Your current usage exceeds the limits for our public endpoints. To access higher rate limits, please visit https://nodies.app and create an account to set up private endpoints. For enterprise usage, please contact [email protected]"
}] test_defaultProposalExecution() (gas: 0)
Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 33.21s (32.20s CPU time)

Ran 1 test suite in 33.21s (33.21s CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in src/20260107_AaveV3InkWhitelabel_TrydoStablecoinIR/AaveV3InkWhitelabel_TrydoStablecoinIR_20260107.t.sol:AaveV3InkWhitelabel_TrydoStablecoinIR_20260107_Test
[FAIL: EVM error; database error: failed to get storage for 0x4cd13ce4edbB5523fd4849252b5f1bF215129D10 at 24440054405305269366569402256811496959409073762505157381672968839269610695612: Max retries exceeded HTTP error 429 with body: {
"message": "Your current usage exceeds the limits for our public endpoints. To access higher rate limits, please visit https://nodies.app and create an account to set up private endpoints. For enterprise usage, please contact [email protected]"
}] test_defaultProposalExecution() (gas: 0)

Encountered a total of 1 failing tests, 0 tests succeeded

@pavelvm5 pavelvm5 merged commit 5887dab into bgd-labs:main Jan 8, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants