Skip to content

refactor: remove direct Vaultwarden fallback#193

Merged
bglusman merged 1 commit into
mainfrom
codex/remove-vaultwarden-fallback
May 12, 2026
Merged

refactor: remove direct Vaultwarden fallback#193
bglusman merged 1 commit into
mainfrom
codex/remove-vaultwarden-fallback

Conversation

@bglusman
Copy link
Copy Markdown
Owner

Summary

  • remove the direct Vaultwarden REST fallback from secrets-client
  • rename the read path from vault to resolver and keep resolution to env -> fnox
  • update docs, install/doctor messaging, and tests to stop advertising direct Vaultwarden support
  • make a credential injection test independent of ambient provider env vars

Vaultwarden can still be used behind fnox as an operator-chosen storage backend; Calciforge no longer calls Vaultwarden APIs or reads SECRETS_VAULT_* directly.

Verification

  • PATH="/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin:/Users/80260986/.codex/tmp/arg0/codex-arg0661YYe:/Users/80260986/.bun/bin:/Users/80260986/.antigravity/antigravity/bin:/Users/80260986/.opencode/bin:/Applications/Postgres.app/Contents/Versions/latest/bin:/Users/80260986/.codeium/windsurf/bin:/Applications/gg.app/Contents/MacOS/:/opt/homebrew/opt/node@14/bin:/Users/brianglusman/.erlangInstaller/23.0.2/bin:/Users/80260986/.asdf/shims:/opt/homebrew/opt/asdf/libexec/bin:/Users/80260986/bin:./bin:/Users/80260986/.duckdb/cli/latest:/Users/80260986/.asdf/installs/nodejs/25.1.0/bin/:/Users/80260986/.local/bin:/Applications/Visual\ Studio\ Code.app/Contents/Resources/app/bin:/opt/homebrew/bin/:/Applications/SnowSQL.app/Contents/MacOS:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/pmk/env/global/bin:/Library/TeX/texbin:/Users/80260986/.cargo/bin:/bin:/Applications/Codex.app/Contents/Resources" RUSTC="/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin/rustc" RUSTDOC="/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin/rustdoc" "/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin/cargo" fmt --all -- --check
  • PATH="/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin:/Users/80260986/.codex/tmp/arg0/codex-arg0661YYe:/Users/80260986/.bun/bin:/Users/80260986/.antigravity/antigravity/bin:/Users/80260986/.opencode/bin:/Applications/Postgres.app/Contents/Versions/latest/bin:/Users/80260986/.codeium/windsurf/bin:/Applications/gg.app/Contents/MacOS/:/opt/homebrew/opt/node@14/bin:/Users/brianglusman/.erlangInstaller/23.0.2/bin:/Users/80260986/.asdf/shims:/opt/homebrew/opt/asdf/libexec/bin:/Users/80260986/bin:./bin:/Users/80260986/.duckdb/cli/latest:/Users/80260986/.asdf/installs/nodejs/25.1.0/bin/:/Users/80260986/.local/bin:/Applications/Visual\ Studio\ Code.app/Contents/Resources/app/bin:/opt/homebrew/bin/:/Applications/SnowSQL.app/Contents/MacOS:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/pmk/env/global/bin:/Library/TeX/texbin:/Users/80260986/.cargo/bin:/bin:/Applications/Codex.app/Contents/Resources" RUSTC="/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin/rustc" RUSTDOC="/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin/rustdoc" "/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin/cargo" test -p secrets-client
  • PATH="/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin:/Users/80260986/.codex/tmp/arg0/codex-arg0661YYe:/Users/80260986/.bun/bin:/Users/80260986/.antigravity/antigravity/bin:/Users/80260986/.opencode/bin:/Applications/Postgres.app/Contents/Versions/latest/bin:/Users/80260986/.codeium/windsurf/bin:/Applications/gg.app/Contents/MacOS/:/opt/homebrew/opt/node@14/bin:/Users/brianglusman/.erlangInstaller/23.0.2/bin:/Users/80260986/.asdf/shims:/opt/homebrew/opt/asdf/libexec/bin:/Users/80260986/bin:./bin:/Users/80260986/.duckdb/cli/latest:/Users/80260986/.asdf/installs/nodejs/25.1.0/bin/:/Users/80260986/.local/bin:/Applications/Visual\ Studio\ Code.app/Contents/Resources/app/bin:/opt/homebrew/bin/:/Applications/SnowSQL.app/Contents/MacOS:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/pmk/env/global/bin:/Library/TeX/texbin:/Users/80260986/.cargo/bin:/bin:/Applications/Codex.app/Contents/Resources" RUSTC="/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin/rustc" RUSTDOC="/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin/rustdoc" "/Users/80260986/.rustup/toolchains/stable-aarch64-apple-darwin/bin/cargo" test -p security-proxy credentials

Copilot AI review requested due to automatic review settings May 12, 2026 13:43
@qodo-code-review
Copy link
Copy Markdown

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@bglusman bglusman merged commit 5b0189f into main May 12, 2026
26 checks passed
@bglusman bglusman deleted the codex/remove-vaultwarden-fallback branch May 12, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants