Integrate embedded WhatsApp and text channels by bglusman · Pull Request #89 · bglusman/calciforge

bglusman · 2026-04-30T11:48:42Z

Summary

Replace the WhatsApp webhook sidecar adapter with embedded zeroclawlabs::WhatsAppWebChannel support.
Add a Linq-backed kind = "sms" Text/iMessage channel for iMessage/RCS/SMS webhooks and replies.
Move Signal onto the outbound message envelope so artifact-producing agents render attachment fallbacks consistently.
Add Matrix 429 retry handling and update channel/agent docs with compile-tested TOML examples.
Extend the local Docker smoke path with optional npcsh/OmO/Gas Town recipe smoke checks.

Verification

cargo check -p calciforge
cargo test -p calciforge test_channel -- --nocapture
cargo test -p calciforge test_agents_doc_full_config_toml_blocks_valid -- --nocapture
cargo test -p calciforge channels::whatsapp::tests -- --nocapture
cargo test -p calciforge channels::sms::tests -- --nocapture
CALCIFORGE_AGENT_RECIPE_SMOKE=1 scripts/manual-docker-test.sh
push hook: fmt, clippy, unit/e2e/doc tests, loom tests, workspace checks

Notes

Live WhatsApp pairing and live Linq delivery still need provider-backed staging credentials. The mocked channel tests cover identity drops, reply target preservation, legacy WhatsApp config rejection, and artifact fallback rendering.

Copilot

Pull request overview

Integrates embedded channel transports (WhatsApp Web + Signal) and adds a new Linq-backed sms channel, while updating docs and smoke tooling to reflect the expanded channel set and improved delivery behavior.

Changes:

Replaces the WhatsApp webhook sidecar with an embedded WhatsAppWebChannel transport loop and adds a new Linq webhook-based sms channel.
Moves Signal/WhatsApp outbound sending to OutboundMessage text fallbacks for consistent artifact rendering.
Adds Matrix 429 retry/backoff handling and updates install/docs + docker smoke scripts for the new channel and recipe smoke option.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
scripts/manual-docker-test.sh	Adds optional agent recipe smoke run under env flag.
scripts/install-calciforge.sh	Updates sample config snippets for embedded WhatsApp/Signal and new `sms` channel.
docs/staging-test-matrix.md	Documents when to run recipe smoke as part of staging verification.
docs/index.md	Updates channel list + adds WhatsApp session and `sms` Linq examples; links to new agents/routing guide.
docs/channels/whatsapp.md	Rewrites WhatsApp setup guide for embedded session transport + migration notes.
docs/channels/sms.md	New setup guide for Linq-backed text/iMessage channel.
docs/agents.md	New guide documenting `[[agents]]`, `[[identities]]`, `[[routing]]` with full-config example.
docs/agent-adapters.md	Mentions running recipe smoke via the docker smoke path.
docs/README.md	Adds `agents.md` to docs index.
crates/calciforge/src/main.rs	Wires up `sms` channel startup/join; updates WhatsApp/Signal startup log text.
crates/calciforge/src/config.rs	Adds `sms` + embedded WhatsApp fields; adds doc TOML block parsing tests (sms + agents.md).
crates/calciforge/src/channels/whatsapp.rs	Replaces webhook receiver with embedded transport listener loop; uses `OutboundMessage` fallback rendering; adds migration rejection + tests.
crates/calciforge/src/channels/telemetry.rs	Updates module docs to include SMS in the cross-channel telemetry schema statement.
crates/calciforge/src/channels/sms.rs	New Linq webhook receiver + dispatch bridge using `OutboundMessage` fallbacks + signature verification support.
crates/calciforge/src/channels/signal.rs	Adds `!secure` handling + switches to `OutboundMessage` fallback rendering path.
crates/calciforge/src/channels/mod.rs	Updates module docs and exports new `sms` channel module.
crates/calciforge/src/channels/matrix.rs	Adds retry handling for Matrix 429 rate-limit responses.
crates/calciforge/Dockerfile	Exposes port 18798 for the SMS webhook listener.
crates/calciforge/Cargo.toml	Enables `zeroclawlabs` feature for WhatsApp Web transport.
README.md	Updates feature table to include text/iMessage routing.
Cargo.lock	Lockfile updates for dependency graph changes from WhatsApp Web enablement.

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated 6 comments.

Copilot

Pull request overview

Copilot reviewed 37 out of 38 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 3 comments.

Copilot · 2026-04-30T14:30:09Z

 <div class="nav">
 <a href="https://github.com/bglusman/calciforge">GitHub</a>
-<a href="https://github.com/bglusman/calciforge/blob/main/README.md">README</a>
-<a href="https://github.com/bglusman/calciforge/tree/main/docs">Docs</a>
+<a href="#quick-install-mac">Install</a>
+<a href="agents.md">Agents</a>
 </div>


The nav link points to agents.md, but the published GitHub Pages site will generate agents.html for that page. Linking to the .md path will likely 404 (or render raw source) in production; use agents.html (or a root-relative /agents.html) to match the rest of the site links.

Copilot · 2026-04-30T14:30:10Z

    /// List ACPX sessions for an agent using the acpx CLI.
    async fn list_acpx_sessions(&self, agent_name: &str) -> Result<Vec<String>, String> {
+        tokio::fs::create_dir_all(crate::adapters::acpx::ACPX_SESSION_DIR)
+            .await
+            .map_err(|e| format!("Failed to create acpx session dir: {}", e))?;
+
        let output = tokio::process::Command::new("acpx")
            .arg(agent_name)
            .arg("sessions")
            .arg("list")
-            .current_dir("/tmp")
+            .current_dir(crate::adapters::acpx::ACPX_SESSION_DIR)
            .output()
            .await
            .map_err(|e| format!("Failed to run acpx: {}", e))?;


list_acpx_sessions awaits Command::output() with no timeout and without kill_on_drop(true). If acpx sessions list hangs (or the task is cancelled), this can stall !sessions handling and potentially leave an orphaned subprocess. Consider adding a reasonable timeout (similar to the adapter) and enabling kill-on-drop for the child process.

Copilot · 2026-04-30T14:30:10Z

+        if let Some(reply) = self.command_handler.handle(&text) {
+            debug!(identity = %identity.id, cmd = %text.trim(), "Text/iMessage: handled pre-auth command");
+            let channel = self.clone();
+            let target = reply_target.clone();
+            tokio::spawn(async move {
+                channel.send_reply(&target, &reply).await;
+            });
+            return;


SMS command handling sends replies but doesn't emit telemetry::command_reply_ready(...) events (unlike Telegram/WhatsApp). Since channels/telemetry.rs explicitly calls out cross-channel comparability (and now mentions SMS), consider adding command telemetry here (pre-auth, unknown, status, switch, etc.) so command latency/volume is observable consistently.

Copilot

Pull request overview

Copilot reviewed 45 out of 46 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

crates/calciforge/src/adapters/acpx.rs:105

ensure_session invokes acpx sessions ensure ... via Command::output().await without kill_on_drop(true) and without using the adapter's existing timeout_ms. If acpx blocks, this can hang dispatch permanently, and cancellation may leave the child process running. Consider setting kill_on_drop(true) and wrapping the wait in tokio::time::timeout(Duration::from_millis(self.timeout_ms), ...), returning a clear AdapterError::Unavailable on timeout.

        let output = Command::new("acpx")
            .arg(&self.agent_name)
            .arg("sessions")
            .arg("ensure")
            .arg("--name")
            .arg(session_name)
            .current_dir(&self.session_dir)
            .envs(&self.env)
            .output()
            .await
            .map_err(|e| AdapterError::Unavailable(format!("Failed to create session: {}", e)))?;

Copilot AI review requested due to automatic review settings April 30, 2026 11:48

This comment was marked as low quality.

Sign in to view

This was referenced Apr 30, 2026

docs: channel setup guides with compile-tested TOML examples #82

Closed

docs: generalize doc standard to all crates and config sections #83

Closed

docs: agents/identities/routing guide + fix flaky Matrix 429 #84

Closed

Copilot started reviewing on behalf of bglusman April 30, 2026 11:49 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread crates/calciforge/src/channels/whatsapp.rs Outdated

Comment thread docs/agents.md

bglusman force-pushed the codex-whatsapp-migration branch from 56a2c0e to b780340 Compare April 30, 2026 12:01

This comment was marked as low quality.

Sign in to view

Copilot AI review requested due to automatic review settings April 30, 2026 12:20

bglusman force-pushed the codex-whatsapp-migration branch from b780340 to b88d845 Compare April 30, 2026 12:20

Copilot started reviewing on behalf of bglusman April 30, 2026 12:21 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread docs/index.md Outdated

bglusman force-pushed the codex-whatsapp-migration branch from b88d845 to 749f060 Compare April 30, 2026 12:30

Copilot AI review requested due to automatic review settings April 30, 2026 12:53

bglusman force-pushed the codex-whatsapp-migration branch from 749f060 to d58b190 Compare April 30, 2026 12:53

Copilot started reviewing on behalf of bglusman April 30, 2026 12:54 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread docs/index.md Outdated

bglusman force-pushed the codex-whatsapp-migration branch from d58b190 to d320b43 Compare April 30, 2026 13:02

Copilot AI review requested due to automatic review settings April 30, 2026 13:13

bglusman force-pushed the codex-whatsapp-migration branch from d320b43 to 2cd9203 Compare April 30, 2026 13:13

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Integrate embedded WhatsApp and text channels

3e480f3

bglusman force-pushed the codex-whatsapp-migration branch from 2cd9203 to 3e480f3 Compare April 30, 2026 13:30

Wire ACPX session selection through chat channels

4b77952

Copilot AI review requested due to automatic review settings April 30, 2026 14:05

Copilot started reviewing on behalf of bglusman April 30, 2026 14:06 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread crates/calciforge/src/adapters/acpx.rs

Comment thread docs/index.md

Comment thread crates/calciforge/src/channels/whatsapp.rs

Address channel review feedback

68bdffb

Address ACPX and WhatsApp review feedback

0955cf7

Copilot AI review requested due to automatic review settings April 30, 2026 14:23

Copilot started reviewing on behalf of bglusman April 30, 2026 14:24 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Fix subprocess proxy guidance

d46c860

Copilot AI review requested due to automatic review settings April 30, 2026 15:12

Copilot started reviewing on behalf of bglusman April 30, 2026 15:13 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

bglusman force-pushed the codex-whatsapp-migration branch from a9cc4b8 to d46c860 Compare April 30, 2026 15:25

bglusman merged commit 608aa7b into main Apr 30, 2026
34 checks passed

bglusman deleted the codex-whatsapp-migration branch April 30, 2026 15:43

Conversation

bglusman commented Apr 30, 2026

Summary

Verification

Notes

Uh oh!

This comment was marked as low quality.

This comment was marked as low quality.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

This comment was marked as low quality.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants