New tool: CleaveRNA#1879
Conversation
|
Hi @reyhaneh-tavakoli We're glad you're back and safe! so can the previous PR be closed? this one:#1739 |
|
The problem is with the |
There was a problem hiding this comment.
Pull request overview
This PR adds a new Galaxy tool wrapper for CleaveRNA under tools/rna_tools/cleaverna, including wrapper XML, macros, Tool Shed metadata, bundled data, and initial test fixtures.
Changes:
- Adds the main
cleaverna.xmlwrapper with training and prediction modes. - Adds shared macros for requirements, parameters, selectors, and citations.
- Adds bundled training/score CSV data plus initial test inputs/expected outputs.
Reviewed changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
tools/rna_tools/cleaverna/cleaverna.xml |
Defines the Galaxy wrapper command, inputs, outputs, tests, help, and required files. |
tools/rna_tools/cleaverna/macros.xml |
Adds reusable tokens, requirements, citations, and parameter macros. |
tools/rna_tools/cleaverna/.shed.yml |
Adds Tool Shed metadata for the new wrapper. |
tools/rna_tools/cleaverna/data/HPBC_target.csv |
Adds bundled HPBC target score data. |
tools/rna_tools/cleaverna/data/SARS_target.csv |
Adds bundled SARS target score data. |
tools/rna_tools/cleaverna/test-data/params.csv |
Adds parameter CSV fixture for the initial test. |
tools/rna_tools/cleaverna/test-data/template.fasta |
Adds FASTA input fixture for the initial test. |
tools/rna_tools/cleaverna/test-data/parameters.cfg |
Adds expected config output placeholder. |
tools/rna_tools/cleaverna/test-data/test_user_merged_num.csv |
Adds expected training CSV output placeholder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --training_file "$training_file" \ | ||
| --training_scores "$training_scores" \ |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Hi Amir, thank you so much! |
|
Here is your error: your files are too big. What are those files? test data? |
|
Maybe just to make it easier, let's remove the option to manually create the CSV files and assume the user will upload them to run the tool. Once the test passed with that option, we add the manual back. What do you think? @reyhaneh-tavakoli |
These files are necessary as training files. If I remember correctly, Björn said that this limitation can be solved. |
I removed all the lines related to the option for manually creating CSV files. Now it only accepts a CSV file in the params command. Let's check it now. |
|
cool, @reyhaneh-tavakoli, please let me know when you've finished your changes |
What is your idea for fixing these errors? |
your zip files are not here. do this: then comit and push |
| #set $params_file = $mode_selector.prediction_mode_selector.params_csv | ||
| ## training file | ||
| #if $mode_selector.prediction_mode_selector.training_file_source.training_file_method == "builtin" | ||
| #set $training_file = "$__tool_directory__/data/" + $mode_selector.prediction_mode_selector.training_file_source.training_builtin | ||
| #else | ||
| #set $training_file = $mode_selector.prediction_mode_selector.training_file_source.training_upload | ||
| #end if | ||
| ## training scores | ||
| #if $mode_selector.prediction_mode_selector.training_scores_source.scores_method == "builtin" | ||
| #set $training_scores = "$__tool_directory__/data/" + $mode_selector.prediction_mode_selector.training_scores_source.scores_builtin | ||
| #else | ||
| #set $training_scores = $mode_selector.prediction_mode_selector.training_scores_source.scores_upload | ||
| #end if | ||
| cleaverna \ | ||
| --prediction_mode default \ | ||
| --params "$params_file" \ | ||
| --model_name "$mode_selector.prediction_mode_selector.model_name" \ | ||
| #for $f in $mode_selector.prediction_mode_selector.target_files_prediction | ||
| --target_files_prediction "$f" \ | ||
| #end for | ||
| --training_file "$training_file"/*.csv \ | ||
| --training_scores "$training_scores" \ | ||
| --output_dir outputs |
| <conditional name="training_file_source"> | ||
| <param name="training_file_method" type="select" label="Training file source"> | ||
| <option value="builtin">Use built‑in</option> | ||
| <option value="upload">Upload ZIP (containing CSV)</option> | ||
| </param> | ||
| <when value="builtin"> | ||
| <param name="training_builtin" type="select" label="Select model"> | ||
| <option value="HPBC_user_merged_num.csv">HPBC</option> | ||
| <option value="SARS_user_merged_num.csv">SARS</option> | ||
| </param> | ||
| </when> | ||
| <when value="upload"> | ||
| <param name="training_upload" type="data" format="zip" label="Upload training ZIP"/> | ||
| </when> | ||
| </conditional> |
| categories: | ||
| - RNA | ||
| description: "Tool for DNAzyme" | ||
| long_description: | | ||
| "scoring candidate cleavage sites of DNAzyme" | ||
|
|
| categories: | ||
| - RNA | ||
| description: "Tool for DNAzyme" | ||
| long_description: | | ||
| "scoring candidate cleavage sites of DNAzyme" | ||
|
|
| name: cleaverna | ||
| owner: bgruening | ||
| remote_repository_url: "https://github.com/bgruening/galaxytools/tools/rna_tools/cleaverna" | ||
| homepage_url: "https://github.com/bgruening/galaxytools/tools/rna_tools/cleaverna" |
|
| <xml name="requirements"> | ||
| <requirements> | ||
| <requirement type="package" version="1.0.0">cleaverna</requirement> | ||
| <requirement type="package" version="8.32">coreutils</requirement> |
There was a problem hiding this comment.
This version does not exist.
When you are using the planemo test locally, please use --biocontainers so the test does not use the packages installed locally in your machine
There was a problem hiding this comment.
Hi, this is still not resolved. The coreutils=8.32 does not exist. That's why your tool is not found.
Please change it to another version.
$ conda create -n test cleaverna=1.0.0 coreutils=8.32
Retrieving notices: done
Channels:
- conda-forge
- bioconda
Platform: linux-64
Collecting package metadata (repodata.json): done
Solving environment: failed
PackagesNotFoundError: The following packages are not available from current channels:
- coreutils=8.32
Current channels:
- https://conda.anaconda.org/conda-forge
- https://conda.anaconda.org/bioconda
To search for alternate channels that may provide the conda package you're
looking for, navigate to
https://anaconda.org
and use the search bar at the top of the page.
…e syntax
- Fix truncated training mode command: change '--output_[...]' to '--output_dir .'
- Fix Cheetah template variable syntax for output files to use ${} instead of $
- Ensures proper command execution and output file name substitution
… issue The test is failing because: 1. CleaveRNA's Feature.py subprocess exits with code 1 2. The underlying tool may have compatibility issues with test data or dependencies Disabling this test temporarily until proper test data and debugging can be completed.
Somehow this file is not generated. |
try this. Your tool is sensitive to file names. |
Thank you so much! Now it’s fixed :) |
@bgruening
@nilchia
Hi. I hope you are doing well. My internet access restrictions disappeared just now after three months. I’ve rewritten both XML files, making a lot of changes. The help and test sections aren’t completed yet, and some labels might still change. I still can’t serve or see the Galaxy interface using Planemo. I added and ran a simple test, but it fails. Could you please help me troubleshoot this?
As soon as it’s fixed, I’ll complete the remaining tests for all modes and update the help section.
I appreciate all your support and assistance.